Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vsphere provider #474

Merged
merged 2 commits into from Jan 25, 2020
Merged

Vsphere provider #474

merged 2 commits into from Jan 25, 2020

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Jan 22, 2020 •
edited

Add support for mao to run the vsphere machine controller.

The machineset controller development was moved into this repo by #441 and the vsphere actuator lives in this repo, therefore the binaries live in the mao image unlike other providers with their own image e.g aws

@enxebre
Add automation for building machineSet and vsphere controllers
b2dbe79
@enxebre
Add support to run vSphere machine controller
8f2ac1a 
The machineset controller development was moved into this repo openshift#441 and the vsphere actuator lives in this repo, therefore the binaries live in the mao image unlike other providers with their own image e.g aws
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 22, 2020
@enxebre
Copy link
Member Author

enxebre commented Jan 22, 2020

/test unit

bison
bison reviewed Jan 22, 2020
View reviewed changes
Dockerfile Show resolved Hide resolved
@enxebre
Copy link
Member Author

enxebre commented Jan 22, 2020

/test unit

1 similar comment
@enxebre
Copy link
Member Author

enxebre commented Jan 22, 2020

/test unit

@enxebre
Copy link
Member Author

enxebre commented Jan 22, 2020

/retest

1 similar comment
@enxebre
Copy link
Member Author

enxebre commented Jan 23, 2020

/retest

@patrickdillon
Copy link
Contributor

Do we need to create a cloud credential request for vsphere similar to other platforms? https://github.com/openshift/machine-api-operator/blob/master/install/0000_30_machine-api-operator_00_credentials-request.yaml

When I run this I get this error:

I0123 18:10:09.749055       1 controller.go:162] padillon-8wclx-worker-zs2ff: reconciling Machine
I0123 18:10:09.749137       1 actuator.go:76] padillon-8wclx-worker-zs2ff: actuator checking if machine exists
E0123 18:10:09.749422       1 controller.go:254] padillon-8wclx-worker-zs2ff: failed to check if machine exists: padillon-8wclx-worker-zs2ff: failed to create scope for machine: padillon-8wclx-worker-zs2ff: error getting credentials: error getting credentials secret openshift-machine-api/vsphere-cloud-credentials: Secret "vsphere-cloud-credentials" not found

@patrickdillon
Copy link
Contributor

When I manually create the credentialrequest the workers are created in vsphere but no node is created:

I0123 21:35:03.151990       1 controller.go:275] padillon-sx25d-worker-2jb4w: has no node yet, requeuing

bison
bison approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bison

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit af2b27e into openshift:master Jan 25, 2020
@openshift-ci-robot
Copy link
Contributor

@enxebre: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 8f2ac1a link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alexander-demicev alexander-demicev mentioned this pull request Feb 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bison bison bison approved these changes

@michaelgugino michaelgugino Awaiting requested review from michaelgugino

Assignees

@bison bison

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@enxebre @patrickdillon @openshift-ci-robot @openshift-bot @bison @openshift-merge-robot