Bug 1814589: [OCPCLOUD-774] Add Node startup timeout API field

[JoelSpeed]

This allows users to set the previously hard coded timeoutForMachineToHaveNode value in the machine health checking algorithm as part of the MachineHealthCheckSpec.

If the value is not set, we default to the original hard coded 10 minute timeout.

Ideally the field would be a metav1.Duration but I've put it as a string because of the same reasons as the UnhealthyCondition.Timeout field.

/cherry-pick release-4.4

/cc @enxebre

[JoelSpeed]

/retest

[enxebre]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[enxebre]

@bison PTAL

[enxebre]

/lgtm

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[JoelSpeed]

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@JoelSpeed: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-azure	f0ce33e	link	/test e2e-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[JoelSpeed]

/cherry-pick release-4.4

[openshift-cherrypick-robot]

@JoelSpeed: new pull request created: #523

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@JoelSpeed: All pull requests linked via external trackers have merged. Bugzilla bug 1814589 has been moved to the MODIFIED state.

In response to this:

Bug 1814589: [OCPCLOUD-774] Add Node startup timeout API field

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JoelSpeed]

/cherry-pick release-4.4

[openshift-cherrypick-robot]

@JoelSpeed: #501 failed to apply on top of branch "release-4.4":

Applying: Use NodeStartupTimeout from MHC rather than const
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	pkg/controller/machinehealthcheck/machinehealthcheck_controller.go
M	pkg/controller/machinehealthcheck/machinehealthcheck_controller_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/controller/machinehealthcheck/machinehealthcheck_controller_test.go
CONFLICT (content): Merge conflict in pkg/controller/machinehealthcheck/machinehealthcheck_controller_test.go
Auto-merging pkg/controller/machinehealthcheck/machinehealthcheck_controller.go
CONFLICT (content): Merge conflict in pkg/controller/machinehealthcheck/machinehealthcheck_controller.go
Patch failed at 0002 Use NodeStartupTimeout from MHC rather than const

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.