Bug 1814582: [release-4.4] [OCPCLOUD-774] Add Node startup timeout API field

[JoelSpeed]

Cherry-pick of #501

Replaces #523 as there were conflicts that needed to be manually resolved

[openshift-ci-robot]

@JoelSpeed: This pull request references Bugzilla bug 1814582, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.4.z) matches configured target release for branch (4.4.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1814589 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1814589 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
• bug has dependents

In response to this:

Bug 1814582: [release-4.4] [OCPCLOUD-774] Add Node startup timeout API field

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Danil-Grigorev]

/approve

[Danil-Grigorev]

/lgtm

[enxebre]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Danil-Grigorev, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[shawn-hurley]

@JoelSpeed

This looks like a feature backports to me (addition of field to a type is what is concerning me.) Can we get justification for the need of this backport?

/cc @mrunalp

[enxebre]

This looks like a feature backports to me (addition of field to a type is what is concerning me.) Can we get justification for the need of this backport?

This is to bug fix a hardcoded narrow timeout consistently with what we do in higher releases. To proactively avoid seeing issues where the timeout wouldn’t be enough and avoid having api skew. The API change is additive and backward compatible with existing default behaviour.

I think we can skip back porting this though and reconsider if we see a customer case coming through if that make sense @JoelSpeed @shawn-hurley .

[JoelSpeed]

Sounds reasonable to me! We can reopen if ever we get a customer case

[openshift-ci-robot]

@JoelSpeed: This pull request references Bugzilla bug 1814582. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 1814582: [release-4.4] [OCPCLOUD-774] Add Node startup timeout API field

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.