-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1840665: [vSphere] Get insecure flag from provider config #597
Bug 1840665: [vSphere] Get insecure flag from provider config #597
Conversation
f99963e
to
a113747
Compare
a113747
to
88ab036
Compare
@alexander-demichev: This pull request references Bugzilla bug 1840665, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
88ab036
to
31d902e
Compare
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks mostly good to me, just had a question about an error print.
pkg/controller/vsphere/util_test.go
Outdated
@@ -67,4 +69,8 @@ func TestGetVSphereConfig(t *testing.T) { | |||
if vSphereConfig.Global.Port != testPort { | |||
t.Errorf("Expected zone %s, got %s", testZone, vSphereConfig.Global.Port) | |||
} | |||
|
|||
if vSphereConfig.Global.InsecureFlag != testInsecureFlag { | |||
t.Errorf("Expected zone %s, got %s", testZone, vSphereConfig.Global.Port) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this error message is the same as the previous message, also it is reporting with the port. is this accurate or should it emit something about the insecure flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, right :D ctrl+C, ctrl+V
31d902e
to
9be1180
Compare
9be1180
to
60eb822
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
11 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@alexander-demichev: All pull requests linked via external trackers have merged: openshift/machine-api-operator#597. Bugzilla bug 1840665 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We should get the insecure flag from provider config and default to secure connection if flag is missing
https://vmware.github.io/vsphere-storage-for-kubernetes/documentation/existing.html#single-vcenter