Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baremetal: configure containers with provisioning_ip #674

Merged
merged 1 commit into from
Aug 12, 2020
Merged

baremetal: configure containers with provisioning_ip #674

merged 1 commit into from
Aug 12, 2020

Conversation

stbenjam
Copy link
Member

When the provisioning network is disabled, provisioning IP is on a
machine network, and we automatically detect the interface to use. We
need to pass the IP into these containers, as well as the interface (if
any is set).

@stbenjam
baremetal: configure containers with provisioning_ip
a3f5dcb 
When the provisioning network is disabled, provisioning IP is on a
machine network, and we automatically detect the interface to use. We
need to pass the IP into these containers, as well as the interface (if
any is set).
@stbenjam
Copy link
Member Author

/assign @sadasu

Could you have a look? I overlooked this missing in the other PR sorry

@sadasu
Copy link
Contributor

sadasu commented Aug 11, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2020
@hardys
Copy link

hardys commented Aug 12, 2020

lgtm - I guess we need a bz for this though?

@stbenjam
Copy link
Member Author

lgtm - I guess we need a bz for this though?

I don’t think so, it hasn’t been turned on yet. Tide isn’t requiring them.

@stbenjam
Copy link
Member Author

/assign @michaelgugino

@stbenjam
Copy link
Member Author

/assign @elmiko

alexander-demicev
alexander-demicev approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demichev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2020
@stbenjam
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@stbenjam
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ea1b907 into openshift:master Aug 12, 2020
@stbenjam stbenjam deleted the env-vars-ironic branch August 12, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelgugino michaelgugino michaelgugino approved these changes

@alexander-demicev alexander-demicev alexander-demicev approved these changes

@Danil-Grigorev Danil-Grigorev Awaiting requested review from Danil-Grigorev

Assignees

@elmiko elmiko

@sadasu sadasu

@michaelgugino michaelgugino

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@stbenjam @sadasu @hardys @openshift-ci-robot @openshift-bot @michaelgugino @alexander-demicev @elmiko @openshift-merge-robot