Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2032296: bump openshift/api #969

Merged
merged 3 commits into from
Dec 14, 2021
Merged

Bug 2032296: bump openshift/api #969

merged 3 commits into from
Dec 14, 2021

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Dec 14, 2021

To teach the webhooks about new fields we have introduced in the API we need to bump the repo. Otherwise new values will be removed.

Ran:

go get -u github.com/openshift/api@6e0b1eb97188300dbb5b0258a6defd285f5caf9b
go mod tidy
go mod vendor

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2021

@Fedosin: This pull request references Bugzilla bug 2032296, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

Bug 2032296: bump openshift/api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fedosin
Pin logr and klog versions
1dec7af 
Due to breaking changes introduced in the libraries, we have to pin
their versions.
@Fedosin
Copy link
Contributor Author

Fedosin commented Dec 14, 2021

/retest

@Fedosin
Bug 2032296: bump openshift/api
0eaf627 
To teach the webhooks about new fields we have introduced in the API
we need to bump the repo. Otherwise new values will be removed.
@Fedosin
Fix breaking changes after upgrading openshift/api
39145d7 
Handler was renamed to ProbeHandler in corev1 API.
JoelSpeed
JoelSpeed reviewed Dec 14, 2021
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2021
alexander-demicev
alexander-demicev approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2021

@Fedosin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-libvirt 39145d7 link false /test e2e-libvirt
ci/prow/e2e-vsphere 39145d7 link false /test e2e-vsphere
ci/prow/e2e-aws-disruptive 39145d7 link false /test e2e-aws-disruptive
ci/prow/e2e-azure-operator 39145d7 link false /test e2e-azure-operator
ci/prow/e2e-metal-ipi-virtualmedia 39145d7 link false /test e2e-metal-ipi-virtualmedia

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 17a2fae into openshift:master Dec 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2021

@Fedosin: All pull requests linked via external trackers have merged:

Bugzilla bug 2032296 has been moved to the MODIFIED state.

In response to this:

Bug 2032296: bump openshift/api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@alexander-demicev alexander-demicev alexander-demicev approved these changes

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

@lobziik lobziik Awaiting requested review from lobziik

Assignees

@alexander-demicev alexander-demicev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Fedosin @openshift-bot @JoelSpeed @alexander-demicev @openshift-merge-robot