Bug 2040620: Rename MAPO image #978
Conversation
The image needed to change name to adhere to conventions.
openshift-ci
bot
added
bugzilla/severity-high
|
@mandre: This pull request references Bugzilla bug 2040620, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/retest-required |
|
/assign @JoelSpeed |
It was previously missing from the image-references. Add it there.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/hold I don't think the naming in the image reference matches the build data, this will need to be double checked |
openshift-ci
bot
added
do-not-merge/hold
| @@ -14,6 +14,10 @@ spec: | |||
| from: | |||
| kind: DockerImage | |||
| name: registry.svc.ci.openshift.org/openshift:openstack-machine-controllers | |||
| - name: openstack-machine-api-provider | |||
There was a problem hiding this comment.
This string needs to match https://github.com/openshift/ocp-build-data/blob/b75c21e23e55142ea58b037d0d4c4e7878b33ba2/images/ose-machine-api-provider-openstack.yml#L25 once you strip the openshift/ose- prefix
There was a problem hiding this comment.
It should be good now thanks to openshift-eng/ocp-build-data#1275.
There was a problem hiding this comment.
The image is not yet available in the 4.10-art-latest image stream though, I'll let you know when we can merge this.
There was a problem hiding this comment.
It's good to go, the image is there now:
$ oc describe imagestream 4.10-art-latest | grep openstack-machine-api-provider
openstack-machine-api-provider
| - name: openstack-machine-api-provider | ||
| from: | ||
| kind: DockerImage | ||
| name: quay.io/openshift/origin-openstack-machine-api-provider |
There was a problem hiding this comment.
I'm still not clear how this ref gets replaced by the one from the release payload, if that's what is really happening.
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/skip |
|
@mandre: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/e2e-aws-upgrade The test failures are unrelated to this PR. This PR does not affect AWS (apart from image build) and as such, given the cluster bootstrapped for the various tasks this clearly hasn't broken anything. Especially as the new image reference is only used with tech preview clusters, this test doesn't make sense here |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mandre: All pull requests linked via external trackers have merged: Bugzilla bug 2040620 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The image needed to change name to adhere to conventions.
Depends on openshift/release#25351