OCPBUGS-5235: Fix mapi_instance_create_failed metric with accelerated networking #46
Conversation
RadekManak
force-pushed
the
fix-cratefailed-metric
branch
from
bcae550
to
9512266
Compare
RadekManak
changed the title
openshift-ci-robot
added
jira/severity-low
|
@RadekManak: This pull request references Jira Issue OCPBUGS-5235, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@RadekManak: This pull request references Jira Issue OCPBUGS-5235, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
| metrics.RegisterFailedInstanceCreate(&metrics.MachineLabels{ | ||
| Name: s.scope.Machine.Name, | ||
| Namespace: s.scope.Machine.Namespace, | ||
| Reason: err.Error(), | ||
| }) | ||
|
|
There was a problem hiding this comment.
Do we normally do this for errors or just invalid machine config? Wondering if this should only be in the first condition of the next if statement, WDYT?
There was a problem hiding this comment.
We increment the metric when we call Azure API with a request needed to create machine that return error e.g. creating machine, IP, interface. We do this for all types of errors. Not just invalid config.
|
@sunzhaohua2 Can we get this verified that it solves the issue. |
|
/lgtm Will add approve once QE have verified |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
/retest-required |
|
@RadekManak: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@RadekManak: Jira Issue OCPBUGS-5235 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.12 |
|
@RadekManak: new pull request created: #115 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
We detect invalid VMsize and Accelerated Networking capability before creating the instance. And not attempt to create it when we know the configuration is invalid.
We should still increment the mapi_instance_create_failed metric if we are unable to create the machine because of invalid VMsize or when accelerated networking is requested and not supported.