Commits on Mar 21, 2023

1. machineset_controller: Report error in fetching flavor info …

   Before this change, a failure in retrieving flavor information from
   OpenStack would trigger a generic event.
   
   With this patch, the warning event signaling failure to retrieve flavor
   information contains the original error coming from the OpenStack API.

   

   pierreprinetti committed Mar 21, 2023
   Copy the full SHA

   6b922ca View commit details

   Browse the repository at this point in the history

2. Remove OpenStackService cache from MachineSet reconciler …

   Caching causes at least two problems:
   * the secret where to look for clouds.yaml is a property of each
     MachineSet (`cloudsSecret` in the Machine template). However, we were
     caching clouds.yaml from the first MachineSet we encountered, and
     using the same for all MachineSets from that point on.
   * by caching (and never invalidating) the OpenStack service client, we
     were not picking up any change to the clouds.yaml itself: for example,
     if the user rotated the cluster's OpenStack credentials.

   

   pierreprinetti committed Mar 21, 2023
   Copy the full SHA

   76f8d0f View commit details

   Browse the repository at this point in the history