Bug 1743160: pkg/controller/kubelet-config: fix owener reference #1022
Conversation
Signed-off-by: Antonio Murdaca <runcom@linux.com>
openshift-ci-robot
added
size/XS
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RobertKrawitz, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Mind including the info from the PRs in commit messages in the future? |
c*ap, I missed that sorry |
|
/cherrypick release-4.1 |
|
@rphillips: new pull request created: #1067 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retitle Bug 1743160: pkg/controller/kubelet-config: fix owener reference |
eparis
changed the title
|
/bugzilla refresh |
1 similar comment
|
/bugzilla refresh |
|
@rphillips: Bugzilla bug 1743160 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Antonio Murdaca runcom@linux.com
- What I did
This fixes a regression introduced in 680f79c#diff-bc0cd3d2a7a92d7ffb804b2d7b2a5636R54 - I think this can cause the resulting kubeletConfig MC to be deleted when the kube GC kicks in but I haven't successfully verified that. Besides, the controller for kubeConfig is
KubeletConfigso fix that.- How to verify it
- Description for the changelog