Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.2] Bug 1757390: Revert: "Temporarily put OpenStack infra pods into non-existing namespace" #1143

Merged
merged 1 commit into from
Oct 25, 2019
Merged

[release-4.2] Bug 1757390: Revert: "Temporarily put OpenStack infra pods into non-existing namespace" #1143

merged 1 commit into from
Oct 25, 2019

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1131

/assign Fedosin

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 1, 2019
Merged
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 1, 2019
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1753067, which is invalid:

  • expected the bug to target the "4.2.0" release, but it targets "4.3.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.2] Bug 1753067: Revert: "Temporarily put OpenStack infra pods into non-existing namespace"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 1, 2019
@Fedosin
Copy link
Contributor

Fedosin commented Oct 1, 2019

/retitle [release-4.2] Bug 1757390: Revert: "Temporarily put OpenStack infra pods into non-existing namespace"

@openshift-ci-robot openshift-ci-robot changed the title [release-4.2] Bug 1753067: Revert: "Temporarily put OpenStack infra pods into non-existing namespace" [release-4.2] Bug 1757390: Revert: "Temporarily put OpenStack infra pods into non-existing namespace" Oct 1, 2019
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1757390, which is invalid:

  • expected the bug to target the "4.2.0" release, but it targets "4.3.0" instead
  • expected dependent Bugzilla bug 1753067 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.2] Bug 1757390: Revert: "Temporarily put OpenStack infra pods into non-existing namespace"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fedosin
Copy link
Contributor

Fedosin commented Oct 1, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@Fedosin: This pull request references Bugzilla bug 1757390, which is invalid:

  • expected the bug to target the "4.2.0" release, but it targets "4.3.0" instead
  • expected dependent Bugzilla bug 1753067 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fedosin
Copy link
Contributor

Fedosin commented Oct 1, 2019

/test e2e-openstack

@Fedosin
Copy link
Contributor

Fedosin commented Oct 1, 2019

OpenStack tests should fail until openshift/origin#23880 is merged

kikisdeliveryservice
kikisdeliveryservice approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding approval. Does other PR need to merge first? Or does it not matter since this is for tests?

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2019
@kikisdeliveryservice
Copy link
Contributor

@Fedosin Looks like you need to fix the BZ's target version the do a bugzilla refresh

@Fedosin
Copy link
Contributor

Fedosin commented Oct 18, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 18, 2019
@openshift-ci-robot
Copy link
Contributor

@Fedosin: This pull request references Bugzilla bug 1757390, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 18, 2019
@Fedosin
Copy link
Contributor

Fedosin commented Oct 18, 2019

/retest

@Fedosin
Copy link
Contributor

Fedosin commented Oct 18, 2019

/test e2e-openstack

@iamemilio
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamemilio, kikisdeliveryservice, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jwforres
Copy link
Member

what happens if a 4.2 cluster is created with the manifests set to "nonexistent" and then upgraded to a cluster with "openshift-openstack-infra" ?

@Fedosin
Copy link
Contributor

Fedosin commented Oct 22, 2019

@jwforres during upgrade MCO recreates all manifests in /etc/kubernetes/manifests and then restarts static pod services, so old pods will be deleted and new ones created

@eparis
Copy link
Member

eparis commented Oct 24, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@eparis: This pull request references Bugzilla bug 1757390, which is valid.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 24, 2019
@openshift-merge-robot openshift-merge-robot merged commit 32b8426 into openshift:release-4.2 Oct 25, 2019
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1757390 has been moved to the MODIFIED state.

In response to this:

[release-4.2] Bug 1757390: Revert: "Temporarily put OpenStack infra pods into non-existing namespace"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

@hardys hardys Awaiting requested review from hardys

Assignees

@iamemilio iamemilio

@Fedosin Fedosin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@openshift-cherrypick-robot @openshift-ci-robot @Fedosin @kikisdeliveryservice @iamemilio @jwforres @eparis @openshift-merge-robot