Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable LocalStorageCapacityIsolation and other featureflags, and update openshift/api #1171

Merged
merged 2 commits into from
Oct 15, 2019

Conversation

rphillips
Copy link
Contributor

@rphillips rphillips commented Oct 14, 2019

- What I did
Related to: openshift/api#462

Two commits:

  • Update openshift/api dependency
  • Update FeatureFlags within the kubelet configs

- How to verify it
Unit tests will pass

- Description for the changelog

LocalStorageCapacityIsolation, NodeDisruptionExclusion,  ServiceNodeExclusion FeatureFlags enabled. LegacyNodeRoleBehavior FeatureFlag disabled.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 14, 2019
@rphillips rphillips changed the title Reenable LocalStorageCapacityIsolation and other featureflags and update openshift/api Reenable LocalStorageCapacityIsolation and other featureflags, and update openshift/api Oct 14, 2019
@rphillips
Copy link
Contributor Author

/test e2e-aws-scaleup-rhel7

Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2019
@openshift-ci-robot
Copy link
Contributor

@rphillips: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 0b0df8f link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@runcom
Copy link
Member

runcom commented Oct 15, 2019

/skip

@runcom
Copy link
Member

runcom commented Oct 15, 2019

/approve

@rphillips is this to try and fix the etcd issue we've been seeing yesterday?

(I'm gonna lgtm afterwards)

@rphillips
Copy link
Contributor Author

@runcom no... This PR is for new featureset enablement.

@runcom
Copy link
Member

runcom commented Oct 15, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, rphillips, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d93f8ca into openshift:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants