*: conditionally populate the images configmap with cluster-etcd-operator image

[alaypatel07]

This adds a flag to MCO for cluster-etcd-operator image and hardcodes
the value to "".

This PR conditionally populates the cluster-etcd-operator image only
if the etcd custom resource exists and if it has a spec field set as
managementState: Managed. It is the same mechanism used
in the installer. This will make sure that the MC rendered during the initial.
boot with the value coming in from the installer flag is always same
as one generate in the sync loop.

With this, we can use a single knob in cluster-etcd-operator
project to test the bootstrap process in CI with cluster-etcd-operator
enabled.

The existence of cluster-etcd-operator image is used to render static
etcd pod yaml. This PR will be followed by another PR which introduces
a boolean flag to be used for conditional rendering of the static pod image.
It will be a more readable way of achieving the same means.

[alaypatel07]

/hold testing this manually

[kikisdeliveryservice]

/skip

[hexfusion]

/retest

[kikisdeliveryservice]

at a quick glance this seems to be failing on masters only so prob the pr? seems etcd server is taking too long: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/1288/pull-ci-openshift-machine-config-operator-master-e2e-aws/5908/artifacts/e2e-aws/pods/openshift-etcd_etcd-member-ip-10-0-137-114.ec2.internal_etcd-member.log

[alaypatel07]

clusterrolebinding.rbac.authorization.k8s.io/system:openshift:controller:resourcequota-controller
E1207 16:34:33.205040       1 watcher.go:214] watch chan error: etcdserver: mvcc: required revision has been compacted
E1207 16:36:17.108350       1 watcher.go:214] watch chan error: etcdserver: mvcc: required revision has been compacted
E1207 16:36:36.023379       1 watcher.go:214] watch chan error: etcdserver: mvcc: required revision has been compacted

Etcd was up but openshift-apiserver had the above error messages, compacted data store, trying again

/test e2e-aws

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[hexfusion]

level=error msg="Error: Error waiting for AMI (ami-0123e5f5f322fe54f) to be ready: timeout while waiting for state to become 'available' (last state: 'pending', timeout: 40m0s)"

/retest

[hexfusion]

level=fatal msg="failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: failed to apply using Terraform"

/test e2e-aws-scaleup-rhel7

[alaypatel07]

digging into the error e2e-gcp-op

/hold
/wip

[alaypatel07]

/test e2e-gcp-op

[hexfusion]

level=error msg="Error: Error applying IAM policy for project "openshift-gce-devel-ci": Error setting IAM policy for project "openshift-gce-devel-ci": googleapi: Error 400: The number of members in the policy (1,501) is larger than the maximum allowed size 1,500., badRequest"

/retest

[hexfusion]

https://prow.svc.ci.openshift.org/job-history/origin-ci-test/pr-logs/directory/pull-ci-openshift-machine-config-operator-master-e2e-gcp-op

Looks like CI is up again.

/retest

[hexfusion]

/joke

[openshift-ci-robot]

@hexfusion: A red and a blue ship have just collided in the Caribbean. Apparently the survivors are marooned.

In response to this:

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hexfusion]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alaypatel07, hexfusion, kikisdeliveryservice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hexfusion]

/hold cancel

[hexfusion]

--- FAIL: TestKernelArguments (448.05s)
mcd_test.go:259: Created kargs-1ac503cd-b15f-43e7-9316-403fe39db164
mcd_test.go:115: Pool worker has rendered config kargs-1ac503cd-b15f-43e7-9316-403fe39db164 with rendered-worker-98c738161d53257c99ec59c65bcaa218 (waited 4.007773128s)
mcd_test.go:263: pool worker didn't report updated to rendered-worker-98c738161d53257c99ec59c65bcaa218: Get https://api.ci-op-7jwmbk77-1354f.origin-ci-int-gce.dev.openshift.com:6443/apis/machineconfiguration.openshift.io/v1/machineconfigpools/worker: dial tcp 35.185.78.239:6443: connect: connection refused

New, I have not see this... last round passed

/test e2e-gcp-op

[openshift-ci-robot]

@alaypatel07: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-vsphere	6f850a18762ee5a1c6a4d1d709fc47938faec5b8	link	/test e2e-vsphere

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[vrutkovs]

/cherrypick fcos

[openshift-cherrypick-robot]

@vrutkovs: new pull request created: #1413

In response to this:

/cherrypick fcos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.