Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1797908: kubelet: Remove quotes from log level argument #1439

Merged
merged 1 commit into from Feb 6, 2020

Conversation

mtnbikenc
Copy link
Member

- What I did
Removed quotes around the KUBELET_LOG_LEVEL variable in the kubelet unit file.
Resolves the following error message produced in kubelet log on RHEL host:

hyperkube[66517]: F0204 19:10:58.178624   66517 server.go:156] invalid argument "\"3\"" for "-v, --v" flag: strconv.ParseInt: parsing "\"3\"": invalid syntax

- How to verify it

- Description for the changelog

Error produced in kubelet log on RHEL host:
hyperkube[66517]: F0204 19:10:58.178624   66517 server.go:156] invalid argument "\"3\"" for "-v, --v" flag: strconv.ParseInt: parsing "\"3\"": invalid syntax
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 4, 2020
@openshift-ci-robot
Copy link
Contributor

@mtnbikenc: This pull request references Bugzilla bug 1797908, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1797908: kubelet: Remove quotes from log level argument

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 4, 2020
@mtnbikenc
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@mtnbikenc: This pull request references Bugzilla bug 1797908, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 4, 2020
@mtnbikenc
Copy link
Member Author

/retest

@cgwalters
Copy link
Member

OK so this came from #1390

Don't quote me on this, but I don't quite see...oh wait, it might be that RHEL8 systemd supports processing quotes, and RHEL7's systemd doesn't?

@mtnbikenc
Copy link
Member Author

/retest

@runcom
Copy link
Member

runcom commented Feb 5, 2020

/retest
/approve

@rphillips ptal for lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2020
@rphillips
Copy link
Contributor

/lgtm

super odd

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2020
@mtnbikenc
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, mtnbikenc, rphillips, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d1acf5f into openshift:master Feb 6, 2020
@openshift-ci-robot
Copy link
Contributor

@mtnbikenc: All pull requests linked via external trackers have merged. Bugzilla bug 1797908 has been moved to the MODIFIED state.

In response to this:

Bug 1797908: kubelet: Remove quotes from log level argument

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtnbikenc mtnbikenc deleted the fix-1797908 branch February 6, 2020 14:24
@openshift-ci-robot
Copy link
Contributor

@mtnbikenc: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 19dee37 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants