Bug 1828112: remove quotes around kubelet_node_ip to account for rhel7 #1736
Conversation
openshift-ci-robot
added
the
bugzilla/severity-high
|
@kikisdeliveryservice: This pull request references Bugzilla bug 1828112, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
testing |
openshift-ci-robot
added
the
do-not-merge/hold
openshift-ci-robot
added
the
approved
|
/test e2e-ovirt |
|
@kikisdeliveryservice: This pull request references Bugzilla bug 1828112, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@kikisdeliveryservice: This pull request references Bugzilla bug 1828112, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mtnbikenc PTAL - is this the necessary fix? |
|
@kikisdeliveryservice: This pull request references Bugzilla bug 1828112, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kikisdeliveryservice That's basically what I was expecting. I just wanted to make sure there were no other aspects of the change to consider. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, rphillips The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-scaleup-rhel7 |
|
wowzers something seems to have gone terribly wrong on this test.. (unrelated to pr) |
|
@kikisdeliveryservice: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
both rhel7&metal-ipi jobs are failing solidly (unrelated to this) - those are known issues. the ovirt test did pass so will remove hold and allow this to merge. /skip |
|
@kikisdeliveryservice: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1736. Bugzilla bug 1828112 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Using approach from #1439 by removing quotes around kubelet_node_ip for rhel7.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1828112