-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make mcfgv1
and ctrlcommon
canonical names for importing
#1472
Conversation
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should pkg/apis/machineconfiguration.openshift.io/install.go
be updated as well?
(And perhaps pkg/generated
, OTOH no-one should ever edit those.)
I found another double import of |
@mtrmac the api package will be moved into the api repo eventually -- I believe it is common practice to spell out the names there and not to shorten them. |
mcfgv1
the canonical name for importing api packagemcfgv1
and ctrcommon
canonical names for importing
mcfgv1
and ctrcommon
canonical names for importingmcfgv1
and ctrlcommon
canonical names for importing
and updated! /hold cancel |
loving this - unfortunately we can't merge this right away as we need to wait at least Monday /hold |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@LorbusChris: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/skip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LorbusChris, mtrmac, runcom, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lifting hold I guess - this has 0 risk /hold cancel |
Entirely code-style.
Not having agreement on the name to use to import the package can lead to not-so-pretty double imports of the same package (as seen here in
container_runtime_config_controller.go
, where the api is imported as bothv1
andmcfgv1
).The same is true for
pkg/controller/common
which is imported with different names across files, and also imported twice in one (render_controller.go
).This PR removes the double imports, and canonicalizes the import names as
mcfgv1
andctrlcommon
across all files in this repo.