Make mcfgv1 and ctrlcommon canonical names for importing

[LorbusChris]

Entirely code-style.

Not having agreement on the name to use to import the package can lead to not-so-pretty double imports of the same package (as seen here in container_runtime_config_controller.go, where the api is imported as both v1 and mcfgv1).
The same is true for pkg/controller/common which is imported with different names across files, and also imported twice in one (render_controller.go).

This PR removes the double imports, and canonicalizes the import names as mcfgv1 and ctrlcommon across all files in this repo.

[umohnani8]

LGTM
thanks @LorbusChris!

[mtrmac]

Should pkg/apis/machineconfiguration.openshift.io/install.go be updated as well?

(And perhaps pkg/generated, OTOH no-one should ever edit those.)

[LorbusChris]

I found another double import of pkg/controller/common, which is also imported with different names in different files. Second commit incoming.
/hold

[LorbusChris]

@mtrmac the api package will be moved into the api repo eventually -- I believe it is common practice to spell out the names there and not to shorten them.

[LorbusChris]

and updated!

/hold cancel

[runcom]

loving this - unfortunately we can't merge this right away as we need to wait at least Monday

/hold

[runcom]

/approve

[mtrmac]

LGTM.

[openshift-ci-robot]

@LorbusChris: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-scaleup-rhel7	65c5038	link	/test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[runcom]

/skip

[yuqi-zhang]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris, mtrmac, runcom, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [runcom,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[runcom]

lifting hold I guess - this has 0 risk

/hold cancel