daemon: Adapt to OS being pre-pivoted #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold Not tested yet. |
openshift-ci-robot
added
size/S
openshift-ci-robot
added
the
approved
|
Now that RHCOS is pre-pivoted (see openshift/os#307), we need to tweak the logic here on how we handle `osImageURL`. Notably, we allow `://dummy` from the installer to always match the current image, regardless of whether we're pivoted or not. In fact, that should've been the logic from the start. Closes: openshift#150
jlebon
force-pushed
the
pr/adapt-pivot
branch
from
780491a
to
eb9bfaa
Compare
ashcrow
approved these changes
Oct 31, 2018
|
This is blocked on libvirt installations working again so that I can test this change. |
|
Will hand off review to @sdemos, but this makes sense to me. |
|
OK, now tested! ✔️ |
|
/lgtm |
|
@jlebon remove the hold when ready |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
osherdp
pushed a commit
to osherdp/machine-config-operator
that referenced
this pull request
Apr 13, 2021
Removed versioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that RHCOS is pre-pivoted (see
openshift/os#307), we need to tweak the logic
here on how we handle
osImageURL. Notably, we allow://dummyfromthe installer to always match the current image, regardless of whether
we're pivoted or not. In fact, that should've been the logic from the
start.
Closes: #150