Support version label, drop legacy stuff, print information before pulling
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for the standard `version` label instead of the old `io.openshift.os-version`. Also just completely drop support for `io.openshift.os-commit`. It's still early and we're moving fast so I think it's not worth it yet to burden ourselves with legacy stuff. Also fix minor typo in error message.
That way we know what we're pulling, before pulling it.
openshift-ci-robot
added
the
size/S
|
Noticed this while testing openshift/machine-config-operator#151. |
ashcrow
reviewed
Nov 1, 2018
| @@ -97,17 +97,14 @@ func Execute(cmd *cobra.Command, args []string) { | |||
| } | |||
|
|
|||
| // Make sure it has a commit label before pulling | |||
| ostree_csum, ok := imagedata.Labels["io.openshift.os-commit"] | |||
| ostree_csum, ok := imagedata.Labels["com.coreos.ostree-commit"] | |||
There was a problem hiding this comment.
Replacing io.openshift.os-commit with com.coreos.ostree-commit? Just verifying as the commit message notes dropping support rather than switching.
There was a problem hiding this comment.
com.coreos.ostree-commit was already supported as a fallback, this is just dropping support for the old one.
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages.