Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "cri-o: set manage_ns_lifecycle to true" #1600

Merged

Conversation

haircommander
Copy link
Member

- What I did
This reverts commit 9b3e28d.
there were some breakages with third party networking plugins as the network ns path changed unexpectedly. revert the switch to cri-o managing namespace lifecycle until this problem is fixed

- How to verify it

- Description for the changelog

CRI-O is no longer managing namespace lifecycle

This reverts commit 9b3e28d.

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander
Copy link
Member Author

/test e2e-aws-ovn

@mrunalp
Copy link
Member

mrunalp commented Mar 31, 2020

/approve

@rphillips
Copy link
Contributor

/lgtm

cc @kikisdeliveryservice

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kikisdeliveryservice, mrunalp, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2020
@kikisdeliveryservice
Copy link
Contributor

The original change doesn't seem to be backported into 4.4 correct?

@rphillips
Copy link
Contributor

Looks like 4.4 is ok. @haircommander ?

@rphillips
Copy link
Contributor

no backport needed

@haircommander
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@umohnani8
Copy link
Contributor

@kikisdeliveryservice yup, it wasn't backported to 4.4

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Apr 1, 2020

Seeing errors in monitoring across a few prs... If this is still happening in the morning, best to report/investigate further.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@stbenjam
Copy link
Member

stbenjam commented Apr 1, 2020

Could we override e2e-gcp-upgrade or figure out what's going on? We're going on 3 days now with our platform broken, and this is just a revert.

@kikisdeliveryservice @haircommander

@stbenjam
Copy link
Member

stbenjam commented Apr 1, 2020

/test e2e-gcp-upgrade

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@stbenjam
Copy link
Member

stbenjam commented Apr 1, 2020

/test e2e-metal-ipi

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Apr 1, 2020

@runcom
Copy link
Member

runcom commented Apr 1, 2020

/refresh

@kikisdeliveryservice
Copy link
Contributor

@ashcrow can we override, this did pass tests but prow isn't reporting correctly..

@ashcrow
Copy link
Member

ashcrow commented Apr 1, 2020

/override e2e-gcp-upgrade

@openshift-ci-robot
Copy link
Contributor

@ashcrow: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • e2e-gcp-upgrade

Only the following contexts were expected:

  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-scaleup-rhel7
  • ci/prow/e2e-gcp-op
  • ci/prow/e2e-gcp-upgrade
  • ci/prow/e2e-metal-ipi
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • tide

In response to this:

/override e2e-gcp-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ashcrow
Copy link
Member

ashcrow commented Apr 1, 2020

/override ci/prow/e2e-gcp-upgrade

@openshift-ci-robot
Copy link
Contributor

@ashcrow: Overrode contexts on behalf of ashcrow: ci/prow/e2e-gcp-upgrade

In response to this:

/override ci/prow/e2e-gcp-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet