Bug 1828106: cloudConfig: remove bare metal from platforms that require a cloud conifg

[stbenjam]

Baremetal IPI doesn't use a cloud config, and this change is now
breaking CI:

level=error msg="Cluster operator machine-config Degraded is True with
RenderConfigFailed: Unable to apply 0.0.1-2020-04-26-200215:
openshift-config-managed/kube-cloud-config configmap is required on
platform BareMetal but not found: configmap \"kube-cloud-config\" not
found"

[openshift-ci-robot]

@stbenjam: This pull request references Bugzilla bug 1828106, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1828106: cloudConfig: remove bare metal from platforms that require a cloud conifg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stbenjam]

/test e2e-metal-ipi

[openshift-ci-robot]

@stbenjam: This pull request references Bugzilla bug 1828106, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1828106: cloudConfig: remove bare metal from platforms that require a cloud conifg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@stbenjam: This pull request references Bugzilla bug 1828106, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1828106: cloudConfig: remove bare metal from platforms that require a cloud conifg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stbenjam]

This is the 2nd PR in almost as many weeks that's broken us just from MCO. After #1600 broke us, we enabled opt-in CI for e2e-metal-ipi. That really should have been run on #1658. Since the opt-in CI is not being used, can we enable it on all PR's at this point?

[stbenjam]

/assign @runcom

[hardys]

/lgtm

[sinnykumari]

Failing test on baremetal makes me wonder does recent cloudConfig change is breaking any other platform too like oVirt? Can someone shade some light on how do we know whether cloudconfig is shipped by a platform or not.
/cc @abhinavdahiya

[sinnykumari]

/retest

[openshift-ci-robot]

@stbenjam: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-scaleup-rhel7	7c6e1ba	link	/test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[stbenjam]

Failing test on baremetal makes me wonder does recent cloudConfig change is breaking any other platform too like oVirt? Can someone shade some light on how do we know whether cloudconfig is shipped by a platform or not.
/cc @abhinavdahiya

I'm not sure, https://github.com/openshift/cluster-config-operator/tree/master/pkg/operator/kube_cloud_config only seems to deal with AWS.

Could we get this change approved and figure out the rest later?

[LorbusChris]

/approve

[sinnykumari]

/approve
/skip

[runcom]

This is the 2nd PR in almost as many weeks that's broken us just from MCO. After #1600 broke us, we enabled opt-in CI for e2e-metal-ipi. That really should have been run on #1658. Since the opt-in CI is not being used, can we enable it on all PR's at this point?

I think that's why we have those jobs in CI right :) I'm in full support of running it all the time - we can do like e2e-aws-scaleup-rhel7 which is not blocking and can be skipped by the team - just make sure that e2e-metal-ipi has an acceptable success rate I guess or we won't be able to debug and distinguish a legit failure from another. @stbenjam can you enable your job making it skippable? This can go in meanwhile.

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys, LorbusChris, runcom, sinnykumari, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [runcom,sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[runcom]

@stbenjam openshift/release#8579

[openshift-ci-robot]

@stbenjam: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1685. Bugzilla bug 1828106 has been moved to the MODIFIED state.

In response to this:

Bug 1828106: cloudConfig: remove bare metal from platforms that require a cloud conifg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.