Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.4] Bug 1820975: ovirt: disable tx checksum offload for workers #1617

Closed
wants to merge 1 commit into from
Closed

[release-4.4] Bug 1820975: ovirt: disable tx checksum offload for workers #1617

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1606

/assign rgolangh

ovirt: disable tx checksum offload for workers
ff4ad79 
This patch adds the workaround suggested on [1]
to make nodeport work, instead of ethtool we use
NM to apply the fix for each connction before it is up.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1794714

Signed-off-by: Gal Zaidman <gzaidman@redhat.com>
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.4] ovirt: disable tx checksum offload for workers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 5, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign ericavonb
You can assign the PR to them by writing /assign @ericavonb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gal-Zaidman
Copy link
Contributor

/retitle [release-4.4] Bug 1820581: ovirt: disable tx checksum offload for workers

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] ovirt: disable tx checksum offload for workers [release-4.4] Bug 1820581: ovirt: disable tx checksum offload for workers Apr 5, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1820581, which is invalid:

  • expected dependent Bugzilla bug 1794714 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
  • expected dependent Bugzilla bug 1820305 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead
  • expected dependent Bugzilla bug 1794714 to target the "4.5.0" release, but it targets "8.2" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.4] Bug 1820581: ovirt: disable tx checksum offload for workers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 5, 2020
@Gal-Zaidman
Copy link
Contributor

/retitle [release-4.4] Bug 1820975: ovirt: disable tx checksum offload for workers

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Bug 1820581: ovirt: disable tx checksum offload for workers [release-4.4] Bug 1820975: ovirt: disable tx checksum offload for workers Apr 5, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1820975, which is invalid:

  • expected Bugzilla bug 1820975 to depend on a bug targeting the "4.5.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.4] Bug 1820975: ovirt: disable tx checksum offload for workers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gal-Zaidman
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@Gal-Zaidman: This pull request references Bugzilla bug 1820975, which is invalid:

  • expected Bugzilla bug 1820975 to depend on a bug targeting the "4.5.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gal-Zaidman
Copy link
Contributor

/test e2e-ovirt

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-op ff4ad79 link /test e2e-gcp-op
ci/prow/e2e-gcp-upgrade ff4ad79 link /test e2e-gcp-upgrade
ci/prow/e2e-aws-scaleup-rhel7 ff4ad79 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rgolangh
Copy link
Contributor

rgolangh commented Apr 5, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@rgolangh: This pull request references Bugzilla bug 1820975, which is invalid:

  • expected dependent Bugzilla bug 1821005 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Gal-Zaidman
Copy link
Contributor

This PR is based on PR#1606 which later got a fix on PR#1621,
We will close it and create a new PR for 4.4 with the fixed version

@Gal-Zaidman
Copy link
Contributor

/close

@openshift-ci-robot
Copy link
Contributor

@Gal-Zaidman: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yuqi-zhang yuqi-zhang mentioned this pull request Apr 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

Assignees

@rgolangh rgolangh

Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@openshift-cherrypick-robot @openshift-ci-robot @Gal-Zaidman @rgolangh