Bug 1820975: oVirt, fix disable tx checksum offload for workers #1628
Conversation
We need to disable tx checksum offload on worker nodes due to BZ#1794714. This is currenly a workaround and is tracked for removal on BZ#18. Signed-off-by: Gal Zaidman <gzaidman@redhat.com>
|
@Gal-Zaidman: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc rgolangh |
|
/lgtm |
|
/retitle Bug 1820975: oVirt, fix disable tx checksum offload for workers |
|
/test e2e-ovirt |
openshift-ci-robot
changed the title
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
@Gal-Zaidman: This pull request references Bugzilla bug 1820975, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@Gal-Zaidman: This pull request references Bugzilla bug 1820975, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
Is this a backport or was it fixed differently in |
|
/hold So generally the proper way is to fix it in 4.5 first by making a PR against master, and once that merges and passes QA, have the bot backport to 4.4. I see you instead duplicated the bug for 4.5, and hand modified that to "Verified" to pass the bot check. I am not sure if you should be doing that unless this is a critical urgent fix. For now please open a PR against 4.5 first (unless this is only something that needs to be fixed for 4.4?). |
openshift-ci-robot
added
the
do-not-merge/hold
|
This was already fixed in master via: #1606 |
@kikisdeliveryservice is right -- there is a fix in |
|
/bugzilla refresh |
openshift-ci-robot
removed
the
bugzilla/valid-bug
|
@ashcrow: This pull request references Bugzilla bug 1820975, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
The bugs should be in the right state now:
Once 1821005 is verified by QE then this can be refreshed and move forward. |
|
Oh I see, the context is in #1617 |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gal-Zaidman, rgolangh, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/skip e2e-aws-scaleup-rhel7 |
|
/skip |
|
/bugzilla refresh |
|
@rgolangh: This pull request references Bugzilla bug 1820975, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@rgolangh: This pull request references Bugzilla bug 1820975, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ashcrow
added
the
cherry-pick-approved
|
@Gal-Zaidman: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Why are we only doing this for workers? In compact clusters (no workers) masters would also need this, no? |
|
@Gal-Zaidman: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1628. Bugzilla bug 1820975 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Gal-Zaidman can you answer @sdodson's question above? |
This fix is to make NodePort work. |
We need to disable tx checksum offload on worker nodes due to BZ#1794714.
This is currenly a workaround and is tracked for removal on BZ#18.
Signed-off-by: Gal Zaidman gzaidman@redhat.com
- What I did
- How to verify it
- Description for the changelog