Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1824940: The Multus CNI configuration file "00-multus.conf" should not be removed #1646

Merged
merged 1 commit into from May 13, 2020
Merged

Bug 1824940: The Multus CNI configuration file "00-multus.conf" should not be removed #1646

merged 1 commit into from May 13, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1623

/assign danehans

@dougbtv
The Multus CNI configuration file "00-multus.conf" should not be remo…
924c001 
…ved.

This is due to the fact that we'd like the nodes to come into a "Ready" state
sooner during an upgrade. Multus CNI has the ability to wait for an indication
of the readiness of the default CNI network (typically, openshift-sdn)
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1821833, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.5.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected Bugzilla bug 1821833 to depend on a bug targeting a release in 4.4.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.3] Bug 1821833: The Multus CNI configuration file "00-multus.conf" should not be removed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 14, 2020
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 14, 2020
Merged
@danehans
Copy link

/retitle [release-4.3] Bug 1824938: The Multus CNI configuration file "00-multus.conf" should not be removed

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] Bug 1821833: The Multus CNI configuration file "00-multus.conf" should not be removed [release-4.3] Bug 1824938: The Multus CNI configuration file "00-multus.conf" should not be removed Apr 16, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1824938, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.3.0" instead
  • expected dependent Bugzilla bug 1821833 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.3] Bug 1824938: The Multus CNI configuration file "00-multus.conf" should not be removed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danehans
Copy link

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@danehans: This pull request references Bugzilla bug 1824938, which is invalid:

  • expected dependent Bugzilla bug 1821833 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danehans
Copy link

/retitle [release-4.3] Bug 1824940: The Multus CNI configuration file "00-multus.conf" should not be removed

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] Bug 1824938: The Multus CNI configuration file "00-multus.conf" should not be removed [release-4.3] Bug 1824940: The Multus CNI configuration file "00-multus.conf" should not be removed Apr 16, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1824940, which is invalid:

  • expected dependent Bugzilla bug 1824936 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
  • expected dependent Bugzilla bug 1824938 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead
  • expected dependent Bugzilla bug 1821833 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead
  • expected dependent Bugzilla bug 1824938 to target a release in 4.4.0, 4.4.z, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.3] Bug 1824940: The Multus CNI configuration file "00-multus.conf" should not be removed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@kikisdeliveryservice: This pull request references Bugzilla bug 1824940, which is invalid:

  • expected dependent Bugzilla bug 1824938 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is CLOSED (NOTABUG) instead
  • expected dependent Bugzilla bug 1821833 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead
  • expected dependent Bugzilla bug 1824938 to target a release in 4.4.0, 4.4.z, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice
Copy link
Contributor

Looks like the associated BZs need to be cleaned up on this @danehans

/approve

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. and removed bugzilla/high labels Apr 23, 2020
@danehans
Copy link

danehans commented May 9, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@danehans: This pull request references Bugzilla bug 1824940, which is invalid:

  • expected dependent Bugzilla bug 1824938 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is CLOSED (DUPLICATE) instead
  • expected dependent Bugzilla bug 1821833 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead
  • expected dependent Bugzilla bug 1824938 to target a release in 4.4.0, 4.4.z, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah
Copy link

Miciah commented May 9, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@Miciah: This pull request references Bugzilla bug 1824940, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1824936 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1824936 targets the "4.4.0" release, which is one of the valid target releases: 4.4.0, 4.4.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 9, 2020
ashcrow
ashcrow approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@ashcrow ashcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport 👍

@ashcrow
Copy link
Member

ashcrow commented May 11, 2020

/retest

@sinnykumari
Copy link
Contributor

Since it is a backport and works as expected in 4.4 and 4.5
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, kikisdeliveryservice, openshift-cherrypick-robot, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ashcrow,kikisdeliveryservice,sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot mentioned this pull request May 13, 2020
Merged
@sdodson
Copy link
Member

sdodson commented May 13, 2020

/retitle Bug 1824940: The Multus CNI configuration file "00-multus.conf" should not be removed

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] Bug 1824940: The Multus CNI configuration file "00-multus.conf" should not be removed Bug 1824940: The Multus CNI configuration file "00-multus.conf" should not be removed May 13, 2020
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 13, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a2645f8 into openshift:release-4.3 May 13, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1646, openshift/multus-cni#65. Bugzilla bug 1824940 has been moved to the MODIFIED state.

In response to this:

Bug 1824940: The Multus CNI configuration file "00-multus.conf" should not be removed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashcrow ashcrow ashcrow approved these changes

@runcom runcom Awaiting requested review from runcom

Assignees

@sinnykumari sinnykumari

@danehans danehans

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet