Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1821833: The Multus CNI configuration file "00-multus.conf" should not be removed #1623

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

dougbtv
Copy link
Member

@dougbtv dougbtv commented Apr 6, 2020

This is due to the fact that we'd like the nodes to come into a "Ready" state
sooner during an upgrade. Multus CNI has the ability to wait for an indication
of the readiness of the default CNI network (typically, openshift-sdn)

…ved.

This is due to the fact that we'd like the nodes to come into a "Ready" state
sooner during an upgrade. Multus CNI has the ability to wait for an indication
of the readiness of the default CNI network (typically, openshift-sdn)
@dougbtv
Copy link
Member Author

dougbtv commented Apr 6, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2020
@smarterclayton
Copy link
Contributor

This looks like it fixed it - after reboot there are none of these messages and node startup is much cleaner (should prevent alerts and spurious warnings). LGTM once it has review from someone else as well.

@smarterclayton
Copy link
Contributor

/retest

@dougbtv
Copy link
Member Author

dougbtv commented Apr 7, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2020
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sane, will defer to an expert to LGTM

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@smarterclayton
Copy link
Contributor

/lgtm

@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, smarterclayton, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@danehans
Copy link

danehans commented Apr 13, 2020

From a CI search, I see the NetworkReady=false reason:NetworkPluginNotReady message:Network plugin returns error: Missing CNI default network error in 4.3.

/cherry-pick release-4.3

@openshift-cherrypick-robot

@danehans: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

In response to this:

From a CI search, I see this error in 4.3 and 4.4.

/cherry-pick release-4.3
/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danehans
Copy link

danehans commented Apr 13, 2020

From a CI search, I see NetworkReady=false reason:NetworkPluginNotReady message:Network plugin returns error: Missing CNI default network error in 4.4.

/cherry-pick release-4.4

@openshift-cherrypick-robot

@danehans: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

From a CI search, I see this error in 4.4.

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danehans
Copy link

/retitle Bug 1821833: The Multus CNI configuration file "00-multus.conf" should not be removed

@openshift-ci-robot openshift-ci-robot changed the title The Multus CNI configuration file "00-multus.conf" should not be removed Bug 1821833: The Multus CNI configuration file "00-multus.conf" should not be removed Apr 13, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 13, 2020
@openshift-ci-robot
Copy link
Contributor

@dougbtv: This pull request references Bugzilla bug 1821833, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1821833: The Multus CNI configuration file "00-multus.conf" should not be removed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danehans
Copy link

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 13, 2020
@openshift-ci-robot
Copy link
Contributor

@danehans: This pull request references Bugzilla bug 1821833, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 13, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 14, 2020

@dougbtv: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 e8309ba link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 50f569f into openshift:master Apr 14, 2020
@openshift-ci-robot
Copy link
Contributor

@dougbtv: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1623. Bugzilla bug 1821833 has been moved to the MODIFIED state.

In response to this:

Bug 1821833: The Multus CNI configuration file "00-multus.conf" should not be removed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@danehans: new pull request created: #1646

In response to this:

From a CI search, I see the NetworkReady=false reason:NetworkPluginNotReady message:Network plugin returns error: Missing CNI default network error in 4.3.

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@danehans: new pull request created: #1647

In response to this:

From a CI search, I see NetworkReady=false reason:NetworkPluginNotReady message:Network plugin returns error: Missing CNI default network error in 4.4.

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants