Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[baremetal] Update keepalived to support both multicast and unicast modes (default=multicast) #1768

Merged
merged 1 commit into from Jul 23, 2020

Conversation

yboaron
Copy link
Contributor

@yboaron yboaron commented Jun 1, 2020

The current deployment workflow relies on the network allowing multicast traffic for VRRP management of the VIP addresses, with this PR keepalived supports both unicast and multicast modes.

To enable unicast keepalived, keepalived.conf in each node should include all the relevant nodes
(including the bootstrap node ) IP addresses, to support this requirement the bootstrap node will run
a simple server that will return its IP address, rest of nodes details will be retrieved from kube-apiserver.

The keepalived mode (unicast or multicast) controlled by 'ENABLE_UNICAST' environment variable, it's set by default to multicast.

- What I did

- How to verify it

- Description for the changelog

@yboaron
Copy link
Contributor Author

yboaron commented Jun 1, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2020
@yboaron
Copy link
Contributor Author

yboaron commented Jun 1, 2020

should be merged after openshift/baremetal-runtimecfg#65

@ashcrow ashcrow requested review from kikisdeliveryservice and removed request for ashcrow June 1, 2020 14:44
@kikisdeliveryservice kikisdeliveryservice changed the title Change to unicast for keepalived [baremetal] Change to unicast for keepalived Jun 3, 2020
@yboaron
Copy link
Contributor Author

yboaron commented Jun 4, 2020

/retest

The current deployment workflow relies on the network allowing multicast traffic for VRRP management of the VIP addresses,
this PR updates keepalived to support also unicast mode.

To enable unicast keepalived, keepalived.conf in each node should include all the relevant nodes
(including the bootstrap node ) IP addresses, to support this requirement the bootstrap node will run
a simple server that will return its IP address, rest of nodes details will be retrieved from kube-apiserver.

The keepalived mode (unicast or multicast) controlled by 'ENABLE_UNICAST' environment variable, it's
set by default to multicast.
@yboaron
Copy link
Contributor Author

yboaron commented Jul 22, 2020

/test e2e-metal-ipi
/test e2e-gcp-upgrade

@yboaron
Copy link
Contributor Author

yboaron commented Jul 22, 2020

openshift/baremetal-runtimecfg#65 was merged, hold can be removed.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2020
@bcrochet
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@yboaron
Copy link
Contributor Author

yboaron commented Jul 22, 2020

/retitle [baremetal] Update keepalived to support both multicast and unicast modes (default=multicast)

@openshift-ci-robot openshift-ci-robot changed the title [baremetal] Change to unicast for keepalived [baremetal] Update keepalived to support both multicast and unicast modes (default=multicast) Jul 22, 2020
@kikisdeliveryservice
Copy link
Contributor

@yboaron is there a reason why you are committing under a different github account?

@yboaronn
Copy link
Contributor

@yboaron is there a reason why you are committing under a different github account?
No, sorry about that. I'll fix that for the next commits.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bcrochet, kikisdeliveryservice, yboaron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bed5205 into openshift:master Jul 23, 2020
mandre added a commit to mandre/machine-config-operator that referenced this pull request Sep 11, 2020
mandre added a commit to mandre/machine-config-operator that referenced this pull request Sep 23, 2020
vrutkovs pushed a commit to vrutkovs/machine-config-operator that referenced this pull request Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants