New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[baremetal] Update keepalived to support both multicast and unicast modes (default=multicast) #1768
[baremetal] Update keepalived to support both multicast and unicast modes (default=multicast) #1768
Conversation
/hold |
should be merged after openshift/baremetal-runtimecfg#65 |
48517da
to
122238a
Compare
122238a
to
0e85207
Compare
/retest |
0e85207
to
4c04978
Compare
4c04978
to
ccfdcf0
Compare
The current deployment workflow relies on the network allowing multicast traffic for VRRP management of the VIP addresses, this PR updates keepalived to support also unicast mode. To enable unicast keepalived, keepalived.conf in each node should include all the relevant nodes (including the bootstrap node ) IP addresses, to support this requirement the bootstrap node will run a simple server that will return its IP address, rest of nodes details will be retrieved from kube-apiserver. The keepalived mode (unicast or multicast) controlled by 'ENABLE_UNICAST' environment variable, it's set by default to multicast.
ccfdcf0
to
c6578a5
Compare
/test e2e-metal-ipi |
openshift/baremetal-runtimecfg#65 was merged, hold can be removed. /hold cancel |
/lgtm |
/retitle [baremetal] Update keepalived to support both multicast and unicast modes (default=multicast) |
@yboaron is there a reason why you are committing under a different github account? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bcrochet, kikisdeliveryservice, yboaron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
Partial port of openshift#1768 to OpenStack platform
Partial port of openshift#1768 to OpenStack platform
Partial port of openshift#1768 to OpenStack platform
The current deployment workflow relies on the network allowing multicast traffic for VRRP management of the VIP addresses, with this PR keepalived supports both unicast and multicast modes.
To enable unicast keepalived, keepalived.conf in each node should include all the relevant nodes
(including the bootstrap node ) IP addresses, to support this requirement the bootstrap node will run
a simple server that will return its IP address, rest of nodes details will be retrieved from kube-apiserver.
The keepalived mode (unicast or multicast) controlled by 'ENABLE_UNICAST' environment variable, it's set by default to multicast.
- What I did
- How to verify it
- Description for the changelog