Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for unicast keepalived #65

Merged
merged 2 commits into from Jul 22, 2020

Conversation

yboaron
Copy link
Contributor

@yboaron yboaron commented Jun 1, 2020

With this PR keepalived capability extended to support both unicast and multicast modes.

The following components were updated to support unicast mode:

  • A simple server that will return node's non-virtual IP address, this server will be used
    by the master nodes to retrieve the bootstrap node IP address. One should contact the server on port 64444.

  • keepalived-monitor can render conf file to support unicast or multicast mode, based on configuration.

@yboaron
Copy link
Contributor Author

yboaron commented Jun 1, 2020

/retest e2e-metal-ipi

@openshift-ci-robot
Copy link
Contributor

@yboaron: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test e2e-metal-ipi
  • /test gofmt
  • /test govet
  • /test images
  • /test unit

Use /test all to run all jobs.

In response to this:

/retest e2e-metal-ipi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yboaron
Copy link
Contributor Author

yboaron commented Jun 1, 2020

/test e2e-metal-ipi

@yboaron yboaron force-pushed the unicast_latest branch 8 times, most recently from ac2044d to 57f7101 Compare June 3, 2020 14:01
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2020
@yboaron yboaron force-pushed the unicast_latest branch 2 times, most recently from 93d7a65 to 8242fd8 Compare June 3, 2020 21:37
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2020
@bcrochet
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

15 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2020
yboaronn and others added 2 commits July 15, 2020 00:31
…be-apiserver

This PR updates LB backends details retrieval code to failover to localhost:kube-apiserver.

Failover to localhost:kube-apiserver also helps to avoid the race between
haproxy-monitor and NM resolv prepend script, for more information check [1].

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1849432
With this PR keepalived capability extended to support both unicast and multicast modes.

The following components were updated to support unicast mode:

- A simple server that will return node's non-virtual IP address, this server will be used
  by the master nodes to retrieve the bootstrap node IP address. One should contact the server on port 64444.

- keepalived-monitor can render conf file to support unicast or multicast mode, based on configuration.
@yboaron
Copy link
Contributor Author

yboaron commented Jul 21, 2020

/test e2e-metal-ipi

1 similar comment
@yboaron
Copy link
Contributor Author

yboaron commented Jul 21, 2020

/test e2e-metal-ipi

@bcrochet
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bcrochet, yboaron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants