[release-4.5] Bug 1846690: daemon: Remove encapsulated config when joining the cluster #1822
Conversation
https://bugzilla.redhat.com/show_bug.cgi?id=1842906 The removal of `BindsTo=` in openshift@75dbab9 I think was completely correct for *new* installs, but creates an upgrade hazard if we happened to be interrupted when the cluster was originally installed as 4.4 or below. Basically the scenario is: - 1st boot: 4.4 install, machine boots the first time - restart.service kills machine-config-daemon-firstboot before it upgrades, or before it unlinks the file - 2nd boot: We stumble on without having pivoted, node joins cluster MCD starts a reboot into 44.81.202006062030-0 which we *should* have updated to before joining the cluster - 3rd boot: Upgraded to 4.5, and the new machine-config-daemon-firstboot without BindsTo= gets laid down in /etc - 4th boot (current): In 4.5, and -firstboot triggers again, trying to finally apply the original config When the MCD (running as a pod) is going we shouldn't run `-firstboot` again, the MCD should handle everything. So just rename the file to signal completion.
|
@openshift-cherrypick-robot: Bugzilla bug 1842906 has been cloned as Bugzilla bug 1846690. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
changed the title
openshift-ci-robot
added
bugzilla/severity-high
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1846690, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
disruptive test is broken |
|
@kikisdeliveryservice: Overrode contexts on behalf of kikisdeliveryservice: ci/prow/e2e-aws-disruptive In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
this is ready to be merged /assign @ashcrow |
ashcrow
added
the
staff-eng-approved
|
👍 |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/e2e-aws-disruptive |
|
@kikisdeliveryservice: Overrode contexts on behalf of kikisdeliveryservice: ci/prow/e2e-aws-disruptive In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1822. Bugzilla bug 1846690 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #1807
/assign cgwalters