Commits on Jun 12, 2020

1. daemon: Remove encapsulated config when joining the cluster …

   https://bugzilla.redhat.com/show_bug.cgi?id=1842906
   
   The removal of `BindsTo=` in openshift@75dbab9
   I think was completely correct for *new* installs, but creates
   an upgrade hazard if we happened to be interrupted when
   the cluster was originally installed as 4.4 or below.
   
   Basically the scenario is:
   
   - 1st boot: 4.4 install, machine boots the first time
   - restart.service kills machine-config-daemon-firstboot before it upgrades, or before it unlinks the file
   - 2nd boot: We stumble on without having pivoted, node joins cluster
     MCD starts a reboot into 44.81.202006062030-0 which we *should* have updated to before joining the cluster
   - 3rd boot: Upgraded to 4.5, and the new machine-config-daemon-firstboot without BindsTo= gets laid down in /etc
   - 4th boot (current): In 4.5, and -firstboot triggers again, trying to finally apply the original config
   
   When the MCD (running as a pod) is going we shouldn't run `-firstboot` again,
   the MCD should handle everything.  So just rename the file to
   signal completion.

   

   cgwalters authored and openshift-cherrypick-robot committed Jun 12, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for a560d03
   • Browse repository at this point

   Copy the full SHA

   a560d03 View commit details

   Browse the repository at this point in the history