New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1848094: [baremetal] Set NonVirtualIP in mdns plugin config #1879
Bug 1848094: [baremetal] Set NonVirtualIP in mdns plugin config #1879
Conversation
In order to avoid sending multicast traffic on all configured interfaces on a system, we need to specify the address of the interface we want to send the traffic on. Because this is a high priority problem on baremetal and (at least to my knowledge) not on other platforms, I'm doing it for baremetal only for now. We can do the other platforms as a followup, but I don't want to hold it up waiting for everyone to sign off.
@cybertron: This pull request references Bugzilla bug 1852126, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@cybertron: This pull request references Bugzilla bug 1848094, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@cybertron: This pull request references Bugzilla bug 1848094, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@cybertron Why aren't the MCO changes necessary in the 4.6 bug? |
They were: #1767 It didn't backport cleanly due to other changes in 4.6. |
/retest |
/test e2e-gcp-upgrade |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: bcrochet, cybertron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@cybertron: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/skip |
@cybertron: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1879, openshift/coredns#32, openshift/coredns-mdns#61. Bugzilla bug 1848094 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In order to avoid sending multicast traffic on all configured
interfaces on a system, we need to specify the address of the
interface we want to send the traffic on.
Because this is a high priority problem on baremetal and (at least
to my knowledge) not on other platforms, I'm doing it for baremetal
only for now. We can do the other platforms as a followup, but I
don't want to hold it up waiting for everyone to sign off.