[baremetal] Set NonVirtualIP in mdns plugin config #1767
Conversation
|
/hold This will need openshift/coredns-mdns#60 to merge and be vendored into coredns, and then new coredns images built before it will work. I'm testing everything together locally in the meantime to verify the fix. |
openshift-ci-robot
added
the
do-not-merge/hold
cybertron
force-pushed
the
mdns-bind-address
branch
from
8f08cac
to
1f209a7
Compare
openshift-ci-robot
added
the
needs-rebase
|
Vendoring proposed in openshift/coredns#31 Once that merges and we have new images this should be good to go. |
cybertron
force-pushed
the
mdns-bind-address
branch
from
1f209a7
to
f3439bc
Compare
openshift-ci-robot
removed
the
needs-rebase
In order to avoid sending multicast traffic on all configured interfaces on a system, we need to specify the address of the interface we want to send the traffic on. Because this is a high priority problem on baremetal and (at least to my knowledge) not on other platforms, I'm doing it for baremetal only for now. We can do the other platforms as a followup, but I don't want to hold it up waiting for everyone to sign off.
cybertron
force-pushed
the
mdns-bind-address
branch
from
f3439bc
to
fc520af
Compare
|
/skip |
|
/hold cancel Looks like we have the new coredns image to support this. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bcrochet, cybertron, kikisdeliveryservice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@cybertron: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/cherry-pick release-4.5 |
|
@cybertron: #1767 failed to apply on top of branch "release-4.5": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is applying the change from openshift#1767 to the other platforms that use mdns. To my knowledge it hasn't been reported as a problem on any of them, but it's still good to do for consistency and to avoid sending multicast traffic to interfaces that don't need it.
In order to avoid sending multicast traffic on all configured
interfaces on a system, we need to specify the address of the
interface we want to send the traffic on.
Because this is a high priority problem on baremetal and (at least
to my knowledge) not on other platforms, I'm doing it for baremetal
only for now. We can do the other platforms as a followup, but I
don't want to hold it up waiting for everyone to sign off.
- Description for the changelog
Configure coredns-mdns to only send multicast traffic on one interface
to avoid sending it to interfaces where it is undesirable.