Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1835145: crio: add temporary hooks directory #1998

Merged
merged 1 commit into from Aug 19, 2020
Merged

Bug 1835145: crio: add temporary hooks directory #1998

merged 1 commit into from Aug 19, 2020

Conversation

haircommander
Copy link
Member

- What I did
Added a temporary directory for cri-o to read hooks dir, so a node powercycle would allow hooks to be recreated rather than use old state
Note: this needs cri-o/cri-o#4052 which should be in nightlies soon. It will probably fail before that
- How to verify it

- Description for the changelog

@haircommander
crio: add temporary hooks directory
51c27ef 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 10, 2020
@openshift-ci-robot
Copy link
Contributor

@haircommander: This pull request references Bugzilla bug 1835145, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1835145: crio: add temporary hooks directory

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice
Copy link
Contributor

/retest

@kikisdeliveryservice
Copy link
Contributor

errr...
/retest

@haircommander
Copy link
Member Author

/hold

gotta sync with psap team on this one

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2020
@haircommander
Copy link
Member Author

/retest

@zvonkok
Copy link

zvonkok commented Aug 17, 2020

/lgtm
We might even obsolete /etc in the future for further use. I will update our docs for hook enablement for correct usage of /run dir for temporary files.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2020
@haircommander
Copy link
Member Author

/hold cancel

@umohnani8 @mrunalp @kikisdeliveryservice PTAL

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2020
@mrunalp
Copy link
Member

mrunalp commented Aug 17, 2020

/lgtm

@haircommander
Copy link
Member Author

/retest

@cgwalters
Copy link
Member

This strongly relates to coreos/fedora-coreos-tracker#354

kikisdeliveryservice
kikisdeliveryservice approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crio pr merged, using /run seems in line with tracker #354, ci is passing (the okd-e2e-aws is red across the board rn). lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2020
@cgwalters
Copy link
Member

Looks like I'll be on the hook to
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, haircommander, kikisdeliveryservice, mrunalp, zvonkok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kikisdeliveryservice
Copy link
Contributor 

level=fatal msg="failed to fetch Metadata: failed to load asset \"Install Config\": failed to unmarshal install-config.yaml: error converting YAML to JSON: yaml: line 49: did not find expected key"

this is supposed to be fixed now.

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@zvonkok
Copy link

zvonkok commented Aug 19, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 19, 2020 •
edited

@haircommander: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-aws 51c27ef link /test okd-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d2f2b79 into openshift:master Aug 19, 2020
@openshift-ci-robot
Copy link
Contributor

@haircommander: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1998, cri-o/cri-o#4052. Bugzilla bug 1835145 has been moved to the MODIFIED state.

In response to this:

Bug 1835145: crio: add temporary hooks directory

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

@mtrmac mtrmac Awaiting requested review from mtrmac

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@mrunalp mrunalp

@zvonkok zvonkok

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@haircommander @openshift-ci-robot @kikisdeliveryservice @zvonkok @mrunalp @cgwalters @openshift-bot @openshift-merge-robot