Dedupe on-prem templates #2079
Dedupe on-prem templates #2079
Conversation
bcrochet
force-pushed
the
templates-dedupe
branch
from
bee6a89
to
85d90b1
Compare
openshift-ci-robot
added
the
needs-rebase
bcrochet
force-pushed
the
templates-dedupe
branch
from
85d90b1
to
690dfdc
Compare
openshift-ci-robot
removed
the
needs-rebase
bcrochet
force-pushed
the
templates-dedupe
branch
from
690dfdc
to
f9f8770
Compare
|
/test e2e-openstack |
|
@bcrochet: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label platform/baremetal |
|
@bcrochet: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
added
the
approved
bcrochet
force-pushed
the
templates-dedupe
branch
from
f9f8770
to
d1da3af
Compare
openshift-ci-robot
removed
the
needs-rebase
bcrochet
force-pushed
the
templates-dedupe
branch
2 times, most recently
from
a78a161
to
fedc2c7
Compare
|
/test e2e-ovirt |
|
@bcrochet: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
bcrochet
force-pushed
the
templates-dedupe
branch
from
fedc2c7
to
ec4eb5a
Compare
|
/retest |
|
/test e2e-ovirt |
|
/retest |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
I put /hold to stop the bot from testing every hour until the conflict will be resolved |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
There are a number of duplicated files across the on-prem platforms. This patch begins the process of de-duplicating them. This is going to be a bigger task than the bootstrap manifests, as not all of the files are duplicated, and some have differences that would not lend to being deduped. But this at least starts small, and proves the concept.
Next step in the deduplication of templates. This targets the NetworkManager files.
This does a dedupe of the CoreDNS related templates. This also has the effect of proving out the "replace with more specific template" option.
bcrochet
force-pushed
the
templates-dedupe
branch
from
51ff382
to
0420e18
Compare
|
/lgtm |
Signed-off-by: Ravid Brown <ravid@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bcrochet, cgwalters, chenyosef, ravidbro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
@bcrochet: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This creates an empty infrastructure.Status.PlatformStatus.VSphere object during UPI installs. Prior to this change, the object has been nil during UPI installs. The object is optional, but a recent change to MCO templating[0] has a dependency on the object. [0]: openshift/machine-config-operator#2079
There are a number of duplicated files across the on-prem platforms.
This patch begins the process of de-duplicating them. This is going
to be a bigger task than the bootstrap manifests, as not all of the
files are duplicated, and some have differences that would not lend
to being deduped. But this at least starts small, and proves the
concept.
- What I did
- How to verify it
- Description for the changelog
Dedupe templates for on-prem platforms