Add kubevirt platform

[ravidbro]

Add KubeVirt as a platform for running OpenShift nodes as VMs.

More details at openshift/enhancements#417

[cgwalters]

I love the idea. So meta!

But I really strongly think before we try to land this in 4.7 we need to invest a lot in de-duping and rationalizing the platform-specific code in the MCO. We simply cannot carry another copy of the kubelet configs for example.

[cgwalters]

Some of that is in #2079

[ravidbro]

Some of that is in #2079

I agree.
When I created the PR I saw that #2079 wasn't approved yet and also that it doesn't contain all the files (e.g. kubelet, keepalived).
I think I will wait for the templates de-dup PR and then I will rebase on it.

[ravidbro]

/retest

[ravidbro]

@cgwalters I changed the PR to have only the bump of openshift/api library and the manifests of the bootstrap based on #2071 .
I will add the required files for the template after #2079 will be merged.

[ravidbro]

/retest

[ravidbro]

/retest

[chenyosef]

/lgtm

[cgwalters]

This must be fixed before this can merge.

[ravidbro]

For now, I removed the guest agent, we can work around without that

[cgwalters]

/hold
For the above at the minimum.
Can you please add a link in the PR and commit message to openshift/enhancements#417 at least?

[ravidbro]

/hold
For the above at the minimum.
Can you please add a link in the PR and commit message to openshift/enhancements#417 at least?

I added a reference to the enhancement both in the PR and in the commit message.

[ravidbro]

/retest

[kikisdeliveryservice]

Q: is installer intending to merge this PR for 4.7? openshift/installer#4350

/override ci/prow/e2e-gcp-op

Please note this job is required for this PR to merge..

[ravidbro]

yes, the installer PR is intended to merge for 4.7.
We need also this (MCO) PR to go in since we are committed for a customer to have dev-preview of this feature in 4.7.
The enhancement is not merged but there is already an agreement on that, you can see @crawford comment

[chenyosef]

It feels premature to merge this seeing that the enhancement is not approved - missing both approved & lgtm) as well as a test plan & dev preview criteria: openshift/enhancements#417

@kikisdeliveryservice Thanks for your review. As for the test plan - our plan is to use the same testing framework as other installer platforms, i.e. using OpenShift CI (you can see WIP in openshift/release#13547, openshift/release#12765, openshift/release#13165), including the conformance testing of the tenant cluster). We will update the enhancement to reflect that (like @ravidbro mentioned, the enhancement itself was already discussed and approved by both PMs and @crawford, even though wasn't merged yet).
More over, as for the timeline - yes, we planned to integrate this to 4.7, and already did so in several other components (openshift/cloud-credential-operator#260, https://github.com/openshift/cluster-api-provider-kubevirt, https://github.com/openshift/release/blob/0ac2cccd3e33a748523cb484a20ea27307a3f8b6/core-services/image-mirroring/openshift/mapping_origin_4_7#L140)

Given the above I don't feel like this should be merged until the above is satisfied.

/hold

Given the above can you please consider removing the hold ?

Thanks,
Chen

[kikisdeliveryservice]

hi @chenyosef & @ravidbro !

Thanks for the info.

2 Qs:

1. what is being delivered for dev preview/alpha? (the enhancement doesn't say)
2. when do you intend on having any basic e2e on this? I'd assume that once all of this merges, we'd be able to reopen WIP Adding e2e kubevirt release#13165 and get that working soon after (so we wouldnt be waiting multiple releases right)?

[ravidbro]

1. The dev preview will have fully functional environment installed as IPI (except of automating csi driver install)
   The reason for the dev preview is that for this version it is tested only by us and the CI and not by QE.
2. We expect the CI to land in the next few weeks

[kikisdeliveryservice]

1. The dev preview will have fully functional environment installed as IPI (except of automating csi driver install)
   The reason for the dev preview is that for this version it is tested only by us and the CI and not by QE.

2. We expect the CI to land in the next few weeks

Great! Thanks for the info! Our gcp-op is required to run and pass before merging this PR but we are having issues with that test for the last week that will be solved once #2229 merges. To avoid unnecessary retests (it will def fail rn), I'll remove the hold tomorrow.

Add: In the meantime it looks like this PR needs a rebase anyway.

[ravidbro]

1. The dev preview will have fully functional environment installed as IPI (except of automating csi driver install)
   The reason for the dev preview is that for this version it is tested only by us and the CI and not by QE.

2. We expect the CI to land in the next few weeks

Great! Thanks for the info! Our gcp-op is required to run and pass before merging this PR but we are having issues with that test for the last week that will be solved once #2229 merges. To avoid unnecessary retests (it will def fail rn), I'll remove the hold tomorrow.

Add: In the meantime it looks like this PR needs a rebase anyway.

Thank you for the review.
I see that the fix was merged and I already rebased my branch to include all the fixes from master.
I will highly appreciate it if you can cancel the hold at this point.

[chenyosef]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bcrochet, chenyosef, ravidbro, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ravidbro]

/retest

[chenyosef]

/retest

[ravidbro]

/retest

[ravidbro]

/retest

[openshift-merge-robot]

@ravidbro: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/okd-e2e-aws	6d005c4	link	/test okd-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[ravidbro]

I see that all tests passed but the 'okd' one which fails constantly on "toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit" because docker started with their rate-limiting.

@kikisdeliveryservice can you cancel the hold?
highly appreciated if you can help us to meet our goal.

[kikisdeliveryservice]

I'm in PST so I just am going thru things.

/hold cancel

[ravidbro]

/skip

[ravidbro]

/retest