Bug 1871769: [baremetal] keep API VIP in the bootstrap node until the bootstrap’s node API goes away #2107

yboaron · 2020-09-21T10:41:34Z

Keeping the API VIP in the bootstrap node until the bootstrap’s node API goes away eliminates
the need for master nodes to specify the bootstrap as one of their peers in the unicast
Keepalived case, see [1].

Additionally, it makes the deployment flow more deterministic so other components
(e.g: remove the requirement for provisioning static IP, see [2] ) can benefit from it.

[1] https://docs.google.com/document/d/1jPIOYuK1J3PKYS8ff8waHWeHqzgl5OZeOkWngUxHtR8/edit?usp=sharing
[2] https://docs.google.com/document/d/18DVr7Ikw_gSJsiQvG8zV2oBEqlG070MzyIElcK94LJI/edit#

When OPENSHIFT_INSTALL_PRESERVE_BOOTSTRAP deployment configuration parameter is set to true the bootstrap node won't be destroyed and infrastructure components including Keepalived on the bootstrap continue to run. With this PR the Keepalived process is stopped when a stop message is received in Keepalived control socket. This change is important for platforms that run Keepalived in unicast mode (baremetal).

yboaron · 2020-09-21T12:45:45Z

/retitle [baremetal, ovirt, vsphere, openstack] keep API VIP in the bootstrap node until the bootstrap’s node API goes away

…s away Keeping the API VIP in the bootstrap node until the bootstrap’s node API goes away eliminates the need for master nodes to specify the bootstrap as one of their peers in the unicast Keepalived case, see [1]. Additionally, it makes the deployment flow more deterministic so other components (e.g: remove requirement for provisioning static IP , see [2] ) can benefit from it. [1] https://docs.google.com/document/d/1jPIOYuK1J3PKYS8ff8waHWeHqzgl5OZeOkWngUxHtR8/edit?usp=sharing [2] https://docs.google.com/document/d/18DVr7Ikw_gSJsiQvG8zV2oBEqlG070MzyIElcK94LJI/edit#

yboaron · 2020-09-21T13:14:09Z

/retitle bug:1881053 [baremetal] keep API VIP in the bootstrap node until the bootstrap’s node API goes away

yboaron · 2020-09-21T13:15:17Z

/retitle bug 1881053: [baremetal] keep API VIP in the bootstrap node until the bootstrap’s node API goes away

openshift-ci-robot · 2020-09-21T13:15:36Z

@yboaron: This pull request references Bugzilla bug 1881053, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

bug 1881053: [baremetal] keep API VIP in the bootstrap node until the bootstrap’s node API goes away

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bcrochet

/lgtm

yboaron · 2020-09-21T15:38:39Z

/test e2e-metal-ipi

openshift-bot · 2020-09-22T01:01:03Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-09-22T01:01:07Z

@openshift-bot: This pull request references Bugzilla bug 1881053, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yboaron · 2020-09-22T06:35:45Z

/retitle Bug 1871769 : [baremetal] keep API VIP in the bootstrap node until the bootstrap’s node API goes away

openshift-ci-robot · 2020-09-22T06:36:02Z

@yboaron: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug 1871769 : [baremetal] keep API VIP in the bootstrap node until the bootstrap’s node API goes away

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yboaron · 2020-09-22T07:01:33Z

/retitle Bug 1871769: [baremetal] keep API VIP in the bootstrap node until the bootstrap’s node API goes away

openshift-ci-robot · 2020-09-22T07:01:54Z

@yboaron: An error was encountered adding this pull request to the external tracker bugs for bug 1871769 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 32000: There was an error reported for a GitHub REST call. URL: https://api.github.com/repos/openshift/machine-config-operator/pulls/2107 Error: 403 Forbidden at /loader/0x558945dcc880/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. at /loader/0x558945dcc880/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. eval {...} called at /loader/0x558945dcc880/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 98 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x55894d...', 'https://api.github.com/repos/openshift/machine-config-operato...', 'GET') called at /loader/0x558945dcc880/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x55894d...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x55894d18f1c8)') called at /loader/0x558945dcc880/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x558945dcc880/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x55894d18f1c8)', 1) called at /loader/0x558945dcc880/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x55894cd7ddc0)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 877 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x55894ce23ce0)', 'HASH(0x55894cc39488)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x55894cc39488)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1170 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x55894cc4d1a0)') called at /loader/0x558945dcc880/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55894cbaa0f8)') called at (eval 2162) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55894cba9e28)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 295 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55894cba9e28)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x55894cc334a8)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x55894ce24088)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x55894ce24088)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x55894cc334a8)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x55894cc334a8)') called at (eval 2162) line 0 eval {...} called at (eval 2162) line 0
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1871769: [baremetal] keep API VIP in the bootstrap node until the bootstrap’s node API goes away

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yboaron · 2020-09-22T07:04:53Z

/bugzilla refresh

openshift-ci-robot · 2020-09-22T07:04:57Z

@yboaron: This pull request references Bugzilla bug 1871769, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yboaron · 2020-09-22T07:13:26Z

/cc @ericavonb

Do you think we can merge this PR ?
The baremetal-runtimecfg PR got merged

manifests/baremetal/keepalived.yaml

yboaron · 2020-09-23T11:58:01Z

@ericavonb Can we merge this PR ?

10x

yuqi-zhang · 2020-09-23T17:50:56Z

/approve

openshift-ci-robot · 2020-09-23T17:51:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bcrochet, cybertron, yboaron, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-09-23T17:51:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-09-23T19:59:28Z

@yboaron: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/okd-e2e-aws	`1537a22`	link	`/test okd-e2e-aws`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-09-23T20:28:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-09-23T20:32:29Z

@yboaron: Some pull requests linked via external trackers have merged:

openshift/machine-config-operator#2107

The following pull requests linked via external trackers have not merged:

openshift/baremetal-runtimecfg#91 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1871769 has not been moved to the MODIFIED state.

In response to this:

Bug 1871769: [baremetal] keep API VIP in the bootstrap node until the bootstrap’s node API goes away

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yuqi-zhang · 2020-09-24T14:20:22Z

/bugzilla refresh

openshift-ci-robot · 2020-09-24T14:20:25Z

@yuqi-zhang: Bugzilla bug 1871769 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from ashcrow and sinnykumari September 21, 2020 10:41

yboaron force-pushed the leave_apivip_on_bootstrap branch from a8e0112 to 590b0a8 Compare September 21, 2020 10:44

openshift-ci-robot changed the title ~~keep API VIP in the bootstrap node until the bootstrap’s node API goes away~~ [baremetal, ovirt, vsphere, openstack] keep API VIP in the bootstrap node until the bootstrap’s node API goes away Sep 21, 2020

yboaron force-pushed the leave_apivip_on_bootstrap branch from 590b0a8 to 1537a22 Compare September 21, 2020 13:13

openshift-ci-robot changed the title ~~[baremetal, ovirt, vsphere, openstack] keep API VIP in the bootstrap node until the bootstrap’s node API goes away~~ bug:1881053 [baremetal] keep API VIP in the bootstrap node until the bootstrap’s node API goes away Sep 21, 2020

openshift-ci-robot changed the title ~~bug:1881053 [baremetal] keep API VIP in the bootstrap node until the bootstrap’s node API goes away~~ bug 1881053: [baremetal] keep API VIP in the bootstrap node until the bootstrap’s node API goes away Sep 21, 2020

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 21, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 21, 2020

ashcrow requested review from ericavonb and removed request for ashcrow September 21, 2020 13:30

bcrochet reviewed Sep 21, 2020

View reviewed changes

openshift-ci-robot assigned bcrochet Sep 21, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2020

openshift-ci-robot changed the title ~~bug 1881053: [baremetal] keep API VIP in the bootstrap node until the bootstrap’s node API goes away~~ Bug 1871769 : [baremetal] keep API VIP in the bootstrap node until the bootstrap’s node API goes away Sep 22, 2020

openshift-ci-robot removed the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 22, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 22, 2020

openshift-ci-robot changed the title ~~Bug 1871769 : [baremetal] keep API VIP in the bootstrap node until the bootstrap’s node API goes away~~ Bug 1871769: [baremetal] keep API VIP in the bootstrap node until the bootstrap’s node API goes away Sep 22, 2020

openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Sep 22, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 22, 2020

cybertron approved these changes Sep 22, 2020

View reviewed changes

manifests/baremetal/keepalived.yaml Show resolved Hide resolved

yboaron mentioned this pull request Sep 23, 2020

Bug 1871769: Keepalived-monitor: delete bootstrap from peers list openshift/baremetal-runtimecfg#91

Closed

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2020

openshift-merge-robot merged commit e715774 into openshift:master Sep 23, 2020

yboaron mentioned this pull request Sep 24, 2020

Bug 1866265: [baremetal] Stop Keepalived on bootstrap after bootstrap completed #2040

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1871769: [baremetal] keep API VIP in the bootstrap node until the bootstrap’s node API goes away #2107

Bug 1871769: [baremetal] keep API VIP in the bootstrap node until the bootstrap’s node API goes away #2107

yboaron commented Sep 21, 2020

yboaron commented Sep 21, 2020

yboaron commented Sep 21, 2020

yboaron commented Sep 21, 2020

openshift-ci-robot commented Sep 21, 2020

bcrochet left a comment

yboaron commented Sep 21, 2020

openshift-bot commented Sep 22, 2020

openshift-ci-robot commented Sep 22, 2020

yboaron commented Sep 22, 2020

openshift-ci-robot commented Sep 22, 2020

yboaron commented Sep 22, 2020

openshift-ci-robot commented Sep 22, 2020

yboaron commented Sep 22, 2020

openshift-ci-robot commented Sep 22, 2020

yboaron commented Sep 22, 2020

yboaron commented Sep 23, 2020

yuqi-zhang commented Sep 23, 2020

openshift-ci-robot commented Sep 23, 2020

openshift-bot commented Sep 23, 2020

openshift-ci-robot commented Sep 23, 2020

openshift-bot commented Sep 23, 2020

openshift-ci-robot commented Sep 23, 2020

yuqi-zhang commented Sep 24, 2020

openshift-ci-robot commented Sep 24, 2020

Bug 1871769: [baremetal] keep API VIP in the bootstrap node until the bootstrap’s node API goes away #2107

Bug 1871769: [baremetal] keep API VIP in the bootstrap node until the bootstrap’s node API goes away #2107

Conversation

yboaron commented Sep 21, 2020

yboaron commented Sep 21, 2020

yboaron commented Sep 21, 2020

yboaron commented Sep 21, 2020

openshift-ci-robot commented Sep 21, 2020

bcrochet left a comment

Choose a reason for hiding this comment

yboaron commented Sep 21, 2020

openshift-bot commented Sep 22, 2020

openshift-ci-robot commented Sep 22, 2020

yboaron commented Sep 22, 2020

openshift-ci-robot commented Sep 22, 2020

yboaron commented Sep 22, 2020

openshift-ci-robot commented Sep 22, 2020

yboaron commented Sep 22, 2020

openshift-ci-robot commented Sep 22, 2020

yboaron commented Sep 22, 2020

yboaron commented Sep 23, 2020

yuqi-zhang commented Sep 23, 2020

openshift-ci-robot commented Sep 23, 2020

openshift-bot commented Sep 23, 2020

openshift-ci-robot commented Sep 23, 2020

openshift-bot commented Sep 23, 2020

openshift-ci-robot commented Sep 23, 2020

yuqi-zhang commented Sep 24, 2020

openshift-ci-robot commented Sep 24, 2020