Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new ShiftStack team member #2165

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Add a new ShiftStack team member #2165

merged 1 commit into from
Oct 21, 2020

Conversation

pierreprinetti
Copy link
Member

No description provided.

mandre
mandre approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2020
Fedosin
Fedosin approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-merge-robot
Copy link
Contributor

@pierreprinetti: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-aws 61c582e link /test okd-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice
Copy link
Contributor

/skip

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, kikisdeliveryservice, mandre, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2020
@openshift-merge-robot openshift-merge-robot merged commit 5a56a3a into openshift:master Oct 21, 2020
@pierreprinetti pierreprinetti deleted the os_add_emilien branch October 21, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre approved these changes

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

@Fedosin Fedosin Fedosin approved these changes

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

@mandre mandre

@Fedosin Fedosin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pierreprinetti @openshift-merge-robot @kikisdeliveryservice @openshift-ci-robot @mandre @Fedosin