Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1898036: Copy files from NM overlay onto /etc/NetworkManager/system-connections #2263

Merged
merged 1 commit into from Dec 2, 2020
Merged

Bug 1898036: Copy files from NM overlay onto /etc/NetworkManager/system-connections #2263

merged 1 commit into from Dec 2, 2020

Conversation

rcarrillocruz
Copy link
Contributor

- What I did

- How to verify it

- Description for the changelog

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2020
@kikisdeliveryservice kikisdeliveryservice requested review from kikisdeliveryservice and removed request for ashcrow November 30, 2020 19:18
@kikisdeliveryservice
Copy link
Contributor

/assign @trozet

@rcarrillocruz rcarrillocruz changed the title WIP Switch NM_CONN_PATH of configure-ovs script to overlay Switch NM_CONN_PATH of configure-ovs script to overlay Dec 1, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2020
@rcarrillocruz rcarrillocruz force-pushed the use_overlay_path_on_configure_ovs branch from 837ce59 to 4875238 Compare December 1, 2020 17:22
@rcarrillocruz rcarrillocruz changed the title Switch NM_CONN_PATH of configure-ovs script to overlay Copy files from NM overlay onto /etc/NetworkManager/system-connections Dec 1, 2020
@rcarrillocruz rcarrillocruz force-pushed the use_overlay_path_on_configure_ovs branch from 4875238 to 9d3ec04 Compare December 1, 2020 17:23
@rcarrillocruz rcarrillocruz force-pushed the use_overlay_path_on_configure_ovs branch from 9d3ec04 to bf586cf Compare December 1, 2020 17:24
@rcarrillocruz rcarrillocruz changed the title Copy files from NM overlay onto /etc/NetworkManager/system-connections Bug 1898036: Copy files from NM overlay onto /etc/NetworkManager/system-connections Dec 1, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Dec 1, 2020
@openshift-ci-robot
Copy link
Contributor

@rcarrillocruz: This pull request references Bugzilla bug 1898036, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1898036: Copy files from NM overlay onto /etc/NetworkManager/system-connections

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 1, 2020
@celebdor
Copy link
Contributor

celebdor commented Dec 1, 2020

The code looks good to me. I'm launching a baremetal ipi deployment with it to verify it

bcrochet
bcrochet approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@celebdor
Copy link
Contributor

celebdor commented Dec 1, 2020

/lgtm

[core@master-0 ~]$ uptime
 18:57:04 up 0 min,  1 user,  load average: 6.47, 1.66, 0.56
[core@master-0 ~]$ ls /etc/NetworkManager/system-connections-merged/
br-ex.nmconnection               ovs-if-br-ex.nmconnection  ovs-port-br-ex.nmconnection
default_connection.nmconnection  ovs-if-phys0.nmconnection  ovs-port-phys0.nmconnection
[core@master-0 ~]$ ls /run/nm-system-connections/
[core@master-0 ~]$ logout
Connection to fd2e:6f44:5dd8:c956::14 closed.

The snippet above shows how after reboot, the upperdir /run/nm-system-connections/ is empty but the connections are in /etc/NetworkManager/system-connections-merged. It also makes it evident that it works since we are SSHed into it.

Finally, all the nodes are ready:

[asegurap@r640-u01 machine-config-operator]$ oc get nodes
NAME                                 STATUS   ROLES    AGE   VERSION
master-0.ostest.test.metalkube.org   Ready    master   64m   v1.19.2+ad738ba
master-1.ostest.test.metalkube.org   Ready    master   60m   v1.19.2+ad738ba
master-2.ostest.test.metalkube.org   Ready    master   59m   v1.19.2+ad738ba
worker-0.ostest.test.metalkube.org   Ready    worker   26m   v1.19.2+ad738ba
worker-1.ostest.test.metalkube.org   Ready    worker   22m   v1.19.2+ad738ba
[asegurap@r640-u01 machine-config-operator]$

@bcrochet
Copy link
Member

bcrochet commented Dec 1, 2020

/test e2e-vsphere
/test e2e-openstack
/test e2e-ovirt

trozet
trozet approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kikisdeliveryservice
Copy link
Contributor

@mandre is this e2e-openstack tests working?

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bcrochet, celebdor, kikisdeliveryservice, rcarrillocruz, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 2, 2020 •
edited

@rcarrillocruz: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-aws bf586cf link /test okd-e2e-aws
ci/prow/e2e-openstack bf586cf link /test e2e-openstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit be1ad78 into openshift:master Dec 2, 2020
@openshift-ci-robot
Copy link
Contributor

@rcarrillocruz: All pull requests linked via external trackers have merged:

Bugzilla bug 1898036 has been moved to the MODIFIED state.

In response to this:

Bug 1898036: Copy files from NM overlay onto /etc/NetworkManager/system-connections

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhat abhat mentioned this pull request Jan 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcrochet bcrochet bcrochet approved these changes

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

@trozet trozet trozet approved these changes

@cgwalters cgwalters Awaiting requested review from cgwalters

Assignees

@bcrochet bcrochet

@celebdor celebdor

@trozet trozet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rcarrillocruz @kikisdeliveryservice @openshift-ci-robot @celebdor @bcrochet @openshift-bot @openshift-merge-robot @trozet