Bug 1910738: [on-prem] fix nodeip-configuration.service template #2326

patrickdillon · 2021-01-07T21:17:12Z

- What I did
Updates the on-prem nodeip-configuration.service template so content is always written but enabled is toggled based on onPremPlatformAPIServerInternalIP. Prior to this change, if onPremPlatformAPIServerInternalIP is nil the enabled is true but content is empty. This change puts the template to be consistent with /pkg/templates/common/_base/units/nodeip-configuration.service.yaml.

- How to verify it
The product of the template can be verified in vSphere UPI CI (and another platform to check the opposite case).

- Description for the changelog
Updates the on-prem nodeip-configuration.service template so content is always written but enabled is toggled based on onPremPlatformAPIServerInternalIP.

Discussion:
I believe this change will mitigate the issues in bz-1917038 but it is not clear to me why vSphere UPI CI does not encounter this issue. Comparing the must-gather from a successful UPI CI run vs the must gather from the BZ I see that the BZ cluster encounters the error in the machine-config-daemon and it looks like there is some sort of update being triggered:

2020-12-24T06:59:46.241456713Z I1224 06:59:46.241389    2389 update.go:588] Checking Reconcilable for config rendered-worker-c255d81fe61657c3062da9e2cfbaee99 to rendered-worker-36aba62b3fbb0fe978bc6a3521af0c3d
2020-12-24T06:59:46.268478900Z I1224 06:59:46.268447    2389 update.go:1844] Starting update from rendered-worker-c255d81fe61657c3062da9e2cfbaee99 to rendered-worker-36aba62b3fbb0fe978bc6a3521af0c3d: &{osUpdate:false kargs:false fips:false passwd:false files:true units:false kernelType:false extensions:false}

This seems to set off the writing of files which leads to the encountered error, but if anyone could shed some light on why this update happens in the BZ but not in CI that would be helpful.

cc @jcpowermac
cc @bcrochet

/test e2e-vsphere-upi

Updates the on-prem nodeip-configuration.service template so content is always written but enabled is toggled based on onPremPlatformAPIServerInternalIP. Prior to this change, if onPremPlatformAPIServerInternalIP is nil the enabled is true but content is empty. This change puts the template to be consistent with /pkg/templates/common/_base/units/nodeip-configuration.service.yaml.

openshift-ci-robot · 2021-01-07T21:17:13Z

@patrickdillon: An error was encountered searching for bug 1917038 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


code 101: Bug #1917038 does not exist.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1917038: fix nodeip-configuration.service template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-07T21:18:48Z

@patrickdillon: An error was encountered adding this pull request to the external tracker bugs for bug 1910738 on the Bugzilla server at https://bugzilla.redhat.com. We were able to detect the following conditions from the error:

The Bugzilla server failed to load data from GitHub when creating the bug. This is usually caused by rate-limiting, please try again later.

Full error message.


JSONRPC error 32000: There was an error reported for the RPC call to Jira: There was an error reported for a GitHub REST call. URL: https://api.github.com/repos/openshift/machine-config-operator/pulls/2326 Error: 403 Forbidden at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. eval {...} called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 98 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559587...', 'https://api.github.com/repos/openshift/machine-config-operato...', 'GET') called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559587...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x5595879687b0)') called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x5595879687b0)', 1) called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x559587940fe0)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x559586d05c60)', 'HASH(0x5595878ffe30)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x5595878ffe30)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x5595878feab0)') called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958733ed28)') called at (eval 2085) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958731fc88)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958731fc88)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x559586db8ed8)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x5595874118f0)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x5595874118f0)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559586db8ed8)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559586db8ed8)') called at (eval 2085) line 0 eval {...} called at (eval 2085) line 0 at /var/www/html/bugzilla/Bugzilla/Error.pm line 130. Bugzilla::Error::_throw_error('global/user-error.html.tmpl', 'ext_bz_rest_error', 'HASH(0x559587968ee8)') called at /var/www/html/bugzilla/Bugzilla/Error.pm line 193 Bugzilla::Error::ThrowUserError('ext_bz_rest_error', 'HASH(0x559587968ee8)') called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 120 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559587...', 'https://api.github.com/repos/openshift/machine-config-operato...', 'GET') called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559587...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x5595879687b0)') called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x5595879687b0)', 1) called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x559587940fe0)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x559586d05c60)', 'HASH(0x5595878ffe30)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x5595878ffe30)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x5595878feab0)') called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958733ed28)') called at (eval 2085) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958731fc88)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958731fc88)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x559586db8ed8)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x5595874118f0)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x5595874118f0)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559586db8ed8)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559586db8ed8)') called at (eval 2085) line 0 eval {...} called at (eval 2085) line 0

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1910738: fix nodeip-configuration.service template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-07T21:19:14Z

@patrickdillon: An error was encountered adding this pull request to the external tracker bugs for bug 1910738 on the Bugzilla server at https://bugzilla.redhat.com. We were able to detect the following conditions from the error:

The Bugzilla server failed to load data from GitHub when creating the bug. This is usually caused by rate-limiting, please try again later.

Full error message.


JSONRPC error 32000: There was an error reported for the RPC call to Jira: There was an error reported for a GitHub REST call. URL: https://api.github.com/repos/openshift/machine-config-operator/pulls/2326 Error: 403 Forbidden at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. eval {...} called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 98 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559587...', 'https://api.github.com/repos/openshift/machine-config-operato...', 'GET') called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559587...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559587393748)') called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559587393748)', 1) called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x5595875f11c8)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x5595874ef7d8)', 'HASH(0x55958685c370)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x55958685c370)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x559586d70430)') called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559587588ad0)') called at (eval 2126) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958761b4e8)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958761b4e8)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x559586d7f5c8)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x559587572538)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x559587572538)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559586d7f5c8)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559586d7f5c8)') called at (eval 2126) line 0 eval {...} called at (eval 2126) line 0 at /var/www/html/bugzilla/Bugzilla/Error.pm line 130. Bugzilla::Error::_throw_error('global/user-error.html.tmpl', 'ext_bz_rest_error', 'HASH(0x55958759b970)') called at /var/www/html/bugzilla/Bugzilla/Error.pm line 193 Bugzilla::Error::ThrowUserError('ext_bz_rest_error', 'HASH(0x55958759b970)') called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 120 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559587...', 'https://api.github.com/repos/openshift/machine-config-operato...', 'GET') called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559587...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559587393748)') called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559587393748)', 1) called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x5595875f11c8)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x5595874ef7d8)', 'HASH(0x55958685c370)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x55958685c370)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x559586d70430)') called at /loader/0x55957cd878b8/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559587588ad0)') called at (eval 2126) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958761b4e8)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55958761b4e8)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x559586d7f5c8)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x559587572538)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x559587572538)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559586d7f5c8)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559586d7f5c8)') called at (eval 2126) line 0 eval {...} called at (eval 2126) line 0

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

@patrickdillon: An error was encountered searching for bug 1917038 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.
code 101: Bug #1917038 does not exist.
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

It doesn't https://bugzilla.redhat.com/show_bug.cgi?id=1910738?

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdodson · 2021-01-07T21:21:51Z

/bugzilla refresh

openshift-ci-robot · 2021-01-07T21:21:57Z

@sdodson: This pull request references Bugzilla bug 1910738, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcpowermac · 2021-01-07T21:39:07Z

/test e2e-vsphere-upi

kikisdeliveryservice · 2021-01-07T21:48:29Z

Hey all, ci seems to be totally down right now, convo in 4-dev

patrickdillon · 2021-01-08T01:40:51Z

/test e2e-vsphere-upi

patrickdillon · 2021-01-08T19:21:52Z

/retest

patrickdillon · 2021-01-08T19:42:42Z

/test e2e-vsphere-upi

jcpowermac · 2021-01-08T19:43:19Z

/test e2e-vsphere-upi

alvaroaleman · 2021-01-08T20:13:45Z

/retest

patrickdillon · 2021-01-11T15:05:54Z

$ cat cluster-scoped-resources/machineconfiguration.openshift.io/machineconfigs/00-worker.yaml shows:

 - contents: |
          [Unit]
          Description=Writes IP address configuration so that kubelet and crio services select a valid node IP
          # This only applies to VIP managing environments where the kubelet and crio IP
          # address picking logic is flawed and may end up selecting an address from a
          # different subnet or a deprecated address
          Wants=network-online.target
          After=network-online.target ignition-firstboot-complete.service
          Before=kubelet.service crio.service

          [Service]
          # Need oneshot to delay kubelet
          Type=oneshot
          # Would prefer to do Restart=on-failure instead of this bash retry loop, but
          # the version of systemd we have right now doesn't support it. It should be
          # available in systemd v244 and higher.
          ExecStart=/bin/bash -c " \
            until \
            /usr/bin/podman run --rm \
            --authfile /var/lib/kubelet/config.json \
            --net=host \
            --volume /etc/systemd/system:/etc/systemd/system:z \
            registry.apps.build01-us-west-2.vmc.ci.openshift.org/ci-op-xc6d35g2/stable@sha256:c95430e348f6bc6d6d9f7b6f9126be814332a5fb1c0d840d4b39ad7b07cca5cf \
            node-ip \
            set --retry-on-failure \
            <no value>; \
            do \
            sleep 5; \
            done"

          [Install]
          WantedBy=multi-user.target
        enabled: false
        name: nodeip-configuration.service

which looks good. Prior to this change, both CI and must-gather from the bz show:

      - contents: ""
        enabled: true
        name: nodeip-configuration.service

Jinyun Ma from QE has told me he is able to reproduce, so should be able to test.

@jcpowermac does this look good to you?

@kikisdeliveryservice how do we do approval for this as it touches on-prem templates (albeit in a small way; do all platforms need to take a look or is this too small to merit attention? I will try to take a look at the CI tests to make sure everything looks good:
/test-e2e-openstack
/test e2e-ovirt
/test e2e-metal-ipi

jcpowermac · 2021-01-11T15:07:08Z

/lgtm

patrickdillon · 2021-01-11T15:09:27Z

Actually e2e-metal-ipi already ran and passed, but it doesn't look like there's a must-gather for the test, so I can't check the manifest. Hopefully oVirt or OpenStack has must-gather as the manifest would be the same.

kikisdeliveryservice · 2021-01-11T17:57:08Z

@patrickdillon let me ping openstack and baremetal on slack to get another 👁️

mandre

LGTM, let's just make sure the tests pass.

/test e2e-openstack

ashcrow · 2021-01-11T18:26:41Z

Will this PR also fix https://bugzilla.redhat.com/show_bug.cgi?id=1909570?

patrickdillon · 2021-01-11T18:49:48Z

Will this PR also fix https://bugzilla.redhat.com/show_bug.cgi?id=1909570?

Yes. I marked 1909570 as a dupe of this BZ.

cybertron · 2021-01-11T19:24:07Z

/lgtm

I'm not sure why this would just be coming up now and only on vsphere upi, but it does seem wrong to have an empty unit enabled. The downside of the fix is that it means the unit will be written on all platforms, but that seems like a lesser evil than having deployments break on other platforms. If it turns out to be a problem we can look for another solution.

kikisdeliveryservice · 2021-01-11T20:36:20Z

Just waiting for that openstack test to finish

/approve
/hold

openshift-ci-robot · 2021-01-11T20:36:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, jcpowermac, kikisdeliveryservice, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kikisdeliveryservice · 2021-01-11T22:40:00Z

something seems wrong with the openstack job finishing but I see:

2021/01/11 19:07:59 Container test in pod e2e-openstack completed successfully

kikisdeliveryservice · 2021-01-11T22:54:25Z

ill try one more time and if it stalls again ill just remove hold EOD

/test e2e-openstack

kikisdeliveryservice · 2021-01-12T00:19:57Z

/test e2e-openstack

kikisdeliveryservice · 2021-01-12T06:08:32Z

Finally!

/hold cancel

kikisdeliveryservice · 2021-01-12T06:09:02Z

/skip

openshift-bot · 2021-01-12T08:12:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-12T08:51:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-12T10:48:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-12T12:58:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-12T16:39:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-12T17:44:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-12T19:28:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-12T22:42:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-01-13T01:22:27Z

@patrickdillon: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/okd-e2e-aws	`87e48ef`	link	`/test okd-e2e-aws`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-01-13T02:23:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-01-13T04:26:00Z

@patrickdillon: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#2326

Bugzilla bug 1910738 has been moved to the MODIFIED state.

In response to this:

Bug 1910738: [on-prem] fix nodeip-configuration.service template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from cgwalters and kikisdeliveryservice January 7, 2021 21:17

patrickdillon changed the title ~~Bug 1917038: fix nodeip-configuration.service template~~ Bug 1910738: fix nodeip-configuration.service template Jan 7, 2021

openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 7, 2021

kikisdeliveryservice changed the title ~~Bug 1910738: fix nodeip-configuration.service template~~ Bug 1910738: [on-prem] fix nodeip-configuration.service template Jan 7, 2021

kikisdeliveryservice assigned jcpowermac, bcrochet and celebdor Jan 7, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2021

kikisdeliveryservice assigned EmilienM and mandre Jan 11, 2021

mandre reviewed Jan 11, 2021

View reviewed changes

openshift-ci-robot assigned cybertron Jan 11, 2021

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2021

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2021

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2021

openshift-merge-robot merged commit 69ac8b9 into openshift:master Jan 13, 2021

Bug 1910738: [on-prem] fix nodeip-configuration.service template #2326

Bug 1910738: [on-prem] fix nodeip-configuration.service template #2326

Conversation

patrickdillon commented Jan 7, 2021

openshift-ci-robot commented Jan 7, 2021

openshift-ci-robot commented Jan 7, 2021

openshift-ci-robot commented Jan 7, 2021

sdodson commented Jan 7, 2021

openshift-ci-robot commented Jan 7, 2021

jcpowermac commented Jan 7, 2021

kikisdeliveryservice commented Jan 7, 2021

patrickdillon commented Jan 8, 2021

patrickdillon commented Jan 8, 2021

patrickdillon commented Jan 8, 2021

jcpowermac commented Jan 8, 2021

alvaroaleman commented Jan 8, 2021

patrickdillon commented Jan 11, 2021

jcpowermac commented Jan 11, 2021

patrickdillon commented Jan 11, 2021

kikisdeliveryservice commented Jan 11, 2021

mandre left a comment

Choose a reason for hiding this comment

ashcrow commented Jan 11, 2021

patrickdillon commented Jan 11, 2021

cybertron commented Jan 11, 2021

kikisdeliveryservice commented Jan 11, 2021

openshift-ci-robot commented Jan 11, 2021

kikisdeliveryservice commented Jan 11, 2021

kikisdeliveryservice commented Jan 11, 2021

kikisdeliveryservice commented Jan 12, 2021

kikisdeliveryservice commented Jan 12, 2021

kikisdeliveryservice commented Jan 12, 2021

openshift-bot commented Jan 12, 2021

openshift-bot commented Jan 12, 2021

openshift-bot commented Jan 12, 2021

openshift-bot commented Jan 12, 2021

openshift-bot commented Jan 12, 2021

openshift-bot commented Jan 12, 2021

openshift-bot commented Jan 12, 2021

openshift-bot commented Jan 12, 2021

openshift-ci bot commented Jan 13, 2021 • edited

openshift-bot commented Jan 13, 2021

openshift-ci-robot commented Jan 13, 2021

openshift-ci bot commented Jan 13, 2021 •

edited