Bug 1921248: KubeletConfig validation warning in CRD and Docs

[harche]

Signed-off-by: Harshal Patil harpatil@redhat.com

Fixes: #2357

- What I did
Add message about KubeletConfig validation in the CRD as well as in docs

- How to verify it
oc explain kubeletconfig.spec.kubeletConfig --recursive=true should show following message,

description: The fields of the kubelet configuration are defined in 
                kubernetes upstream. Please refer to the types defined in the 
                version/commit used by OpenShift of the upstream kubernetes.
                It's importent to note that, since the fields of the kubelet
                configuration are directly fetched from upstream the validation 
                of those values is handled directly by the kubelet. Please refer 
                to the upstream version of the relavent kubernetes for the 
                valid values of these fields. Invalid values of the kubelet
                configuration fields may render cluster nodes unusable.

- Description for the changelog
KubeletConfig validation warning in CRD and Docs

[harche]

/cc @rphillips

[rphillips]

Extremely well stated.

/retest
/lgtm

[kikisdeliveryservice]

no bz hold for 4.8

/hold

[harche]

@kikisdeliveryservice The BZ is missing deliberately. The main motivation behind this PR is BZs like, https://bugzilla.redhat.com/show_bug.cgi?id=1891460

We have taken a decision to not endlessly keep replicating the validation from upstream kubelet config in MCO. So I have added a warning for user about the validation in the KubeletConfig CRD.

Once this PR merges, I plan to close that BZ with WONTFIX and point to this issue for helping them understand why the BZ is closed with WONTFIX

/cc @rphillips

[rphillips]

/retitle Bug 1921248: KubeletConfig validation warning in CRD and Docs

[openshift-ci-robot]

@harche: This pull request references Bugzilla bug 1921248, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1921248: KubeletConfig validation warning in CRD and Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rphillips]

/lgtm
/retest

[rphillips]

/bugzilla refresh

[openshift-ci-robot]

@rphillips: This pull request references Bugzilla bug 1921248, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kikisdeliveryservice]

Thanks for updating @harche

❤️ this will be super helpful for users.

[kikisdeliveryservice]

/hold cancel

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harche, kikisdeliveryservice, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@harche: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#2358

Bugzilla bug 1921248 has been moved to the MODIFIED state.

In response to this:

Bug 1921248: KubeletConfig validation warning in CRD and Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[harche]

/cherry-pick release-4.6

[openshift-cherrypick-robot]

@harche: #2358 failed to apply on top of branch "release-4.6":

Applying: KubeletConfig validation warning in CRD and Docs
.git/rebase-apply/patch:16: trailing whitespace.
It's importent to note that, since the fields of the kubelet configuration are directly fetched from upstream the validation 
.git/rebase-apply/patch:17: trailing whitespace.
of those values is handled directly by the kubelet. Please refer to the upstream version of the relavent kubernetes for the 
.git/rebase-apply/patch:34: trailing whitespace.
                configuration are directly fetched from upstream the validation 
.git/rebase-apply/patch:35: trailing whitespace.
                of those values is handled directly by the kubelet. Please refer 
.git/rebase-apply/patch:36: trailing whitespace.
                to the upstream version of the relavent kubernetes for the 
warning: 5 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	docs/KubeletConfigDesign.md
M	install/0000_80_machine-config-operator_01_kubeletconfig.crd.yaml
Falling back to patching base and 3-way merge...
Auto-merging install/0000_80_machine-config-operator_01_kubeletconfig.crd.yaml
CONFLICT (content): Merge conflict in install/0000_80_machine-config-operator_01_kubeletconfig.crd.yaml
Auto-merging docs/KubeletConfigDesign.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 KubeletConfig validation warning in CRD and Docs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.