[release-4.6] Bug 1975626: KubeletConfig validation warning in CRD and Docs #2672

QiWang19 · 2021-07-09T20:02:15Z

Close https://bugzilla.redhat.com/show_bug.cgi?id=1975626
- What I did
Backport of #2358 since the cherrypick robot failed. #2358 (comment)
- How to verify it

- Description for the changelog

openshift-ci · 2021-07-09T20:02:19Z

@QiWang19: This pull request references Bugzilla bug 1975626, which is invalid:

expected the bug to target the "4.6.z" release, but it targets "---" instead
expected Bugzilla bug 1975626 to depend on a bug targeting a release in 4.7.0, 4.7.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1975626: KubeletConfig validation warning in CRD and Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

QiWang19 · 2021-07-09T20:28:52Z

/bugzilla refresh

openshift-ci · 2021-07-09T20:28:55Z

@QiWang19: This pull request references Bugzilla bug 1975626, which is invalid:

expected Bugzilla bug 1975626 to depend on a bug targeting a release in 4.7.0, 4.7.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

QiWang19 · 2021-07-09T20:31:54Z

/bugzilla refresh

openshift-ci · 2021-07-09T20:31:58Z

@QiWang19: This pull request references Bugzilla bug 1975626, which is invalid:

expected dependent Bugzilla bug 1891460 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is CLOSED (WONTFIX) instead
expected dependent Bugzilla bug 1891460 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

QiWang19 · 2021-07-10T03:28:53Z

/test okd-e2e-gcp-op

sinnykumari · 2021-07-12T09:05:53Z

docs/KubeletConfigDesign.md

@@ -61,6 +61,12 @@ KubeletConfig
  [KubeletConfigurationSpec](https://github.com/kubernetes/kubernetes/blob/release-1.11/pkg/kubelet/apis/kubeletconfig/v1beta1/types.go#L45)
 ```

+## VALIDATION
+
+It's importent to note that, since the fields of the kubelet configuration are directly fetched from upstream the validation


typo: important

sinnykumari · 2021-07-12T09:06:16Z

install/0000_80_machine-config-operator_01_kubeletconfig.crd.yaml

+              description: The fields of the kubelet configuration are defined in
+                kubernetes upstream. Please refer to the types defined in the
+                version/commit used by OpenShift of the upstream kubernetes.
+                It's importent to note that, since the fields of the kubelet


typo important

sinnykumari · 2021-07-12T09:07:56Z

This bug should depends on BZ#1921248

Signed-off-by: Harshal Patil <harpatil@redhat.com> Signed-off-by: Qi Wang <qiwan@redhat.com>

QiWang19 · 2021-07-12T14:40:32Z

/bugzilla refresh

openshift-ci · 2021-07-12T14:41:46Z

@QiWang19: An error was encountered querying GitHub for users with public email (minmli@redhat.com) for bug 1975626 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#abuse-rate-limits\",\n  \"message\": \"You have triggered an abuse detection mechanism. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

QiWang19 · 2021-07-12T15:15:33Z

/bugzilla refresh

openshift-ci · 2021-07-12T15:15:39Z

@QiWang19: This pull request references Bugzilla bug 1975626, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1921248 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1921248 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
bug has dependents

Requesting review from QA contact:
/cc @lyman9966

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

QiWang19 · 2021-07-12T15:16:22Z

@sinnykumari fixed reviews. PTAL.

openshift-ci · 2021-07-12T17:04:50Z

@QiWang19: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/okd-e2e-aws	`8136a89`	link	`/test okd-e2e-aws`
ci/prow/e2e-metal-ipi	`8136a89`	link	`/test e2e-metal-ipi`
ci/prow/okd-e2e-gcp-op	`8136a89`	link	`/test okd-e2e-gcp-op`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kikisdeliveryservice

/lgtm

openshift-ci · 2021-07-12T22:13:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, QiWang19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kikisdeliveryservice · 2021-07-12T22:14:01Z

/skip

openshift-ci · 2021-07-14T19:13:08Z

@QiWang19: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#2672

Bugzilla bug 1975626 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1975626: KubeletConfig validation warning in CRD and Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 9, 2021

openshift-ci bot requested review from ashcrow and yuqi-zhang July 9, 2021 20:02

sinnykumari requested review from sinnykumari and removed request for ashcrow July 12, 2021 09:01

sinnykumari reviewed Jul 12, 2021

View reviewed changes

KubeletConfig validation warning in CRD and Docs

8136a89

Signed-off-by: Harshal Patil <harpatil@redhat.com> Signed-off-by: Qi Wang <qiwan@redhat.com>

QiWang19 force-pushed the backport-2358 branch from e5a62b0 to 8136a89 Compare July 12, 2021 14:40

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 12, 2021

openshift-ci bot requested a review from lyman9966 July 12, 2021 15:15

kikisdeliveryservice changed the title ~~Bug 1975626: KubeletConfig validation warning in CRD and Docs~~ [release-4.6] Bug 1975626: KubeletConfig validation warning in CRD and Docs Jul 12, 2021

kikisdeliveryservice approved these changes Jul 12, 2021

View reviewed changes

openshift-ci bot assigned kikisdeliveryservice Jul 12, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2021

kikisdeliveryservice added the 4.6 Work targeted for 4.6 label Jul 12, 2021

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 14, 2021

openshift-merge-robot merged commit e730721 into openshift:release-4.6 Jul 14, 2021

openshift-ci bot mentioned this pull request Aug 6, 2021

Bug 1975626: Fix KubeletConfig nil error #2699

Merged

openshift-ci bot mentioned this pull request Aug 26, 2021

Bug 1975626: Add nil check for KubeletConfig #2719

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-4.6] Bug 1975626: KubeletConfig validation warning in CRD and Docs #2672

[release-4.6] Bug 1975626: KubeletConfig validation warning in CRD and Docs #2672

QiWang19 commented Jul 9, 2021

openshift-ci bot commented Jul 9, 2021

QiWang19 commented Jul 9, 2021

openshift-ci bot commented Jul 9, 2021

QiWang19 commented Jul 9, 2021

openshift-ci bot commented Jul 9, 2021

QiWang19 commented Jul 10, 2021

sinnykumari Jul 12, 2021

sinnykumari Jul 12, 2021

sinnykumari commented Jul 12, 2021

QiWang19 commented Jul 12, 2021

openshift-ci bot commented Jul 12, 2021

QiWang19 commented Jul 12, 2021

openshift-ci bot commented Jul 12, 2021

QiWang19 commented Jul 12, 2021

openshift-ci bot commented Jul 12, 2021

kikisdeliveryservice left a comment

openshift-ci bot commented Jul 12, 2021

kikisdeliveryservice commented Jul 12, 2021

openshift-ci bot commented Jul 14, 2021

[release-4.6] Bug 1975626: KubeletConfig validation warning in CRD and Docs #2672

[release-4.6] Bug 1975626: KubeletConfig validation warning in CRD and Docs #2672

Conversation

QiWang19 commented Jul 9, 2021

openshift-ci bot commented Jul 9, 2021

QiWang19 commented Jul 9, 2021

openshift-ci bot commented Jul 9, 2021

QiWang19 commented Jul 9, 2021

openshift-ci bot commented Jul 9, 2021

QiWang19 commented Jul 10, 2021

sinnykumari Jul 12, 2021

Choose a reason for hiding this comment

sinnykumari Jul 12, 2021

Choose a reason for hiding this comment

sinnykumari commented Jul 12, 2021

QiWang19 commented Jul 12, 2021

openshift-ci bot commented Jul 12, 2021

QiWang19 commented Jul 12, 2021

openshift-ci bot commented Jul 12, 2021

QiWang19 commented Jul 12, 2021

openshift-ci bot commented Jul 12, 2021

kikisdeliveryservice left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jul 12, 2021

kikisdeliveryservice commented Jul 12, 2021

openshift-ci bot commented Jul 14, 2021