Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Bug 1992687: alerts: SystemMemoryExceedsReservation triggers too quickly #2710

Merged
merged 1 commit into from Aug 11, 2021
Merged

[release-4.7] Bug 1992687: alerts: SystemMemoryExceedsReservation triggers too quickly #2710

merged 1 commit into from Aug 11, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2508

/assign cblecker

@smarterclayton
alerts: SystemMemoryExceedsReservation triggers too quickly
bfa4009 
As a warning, the alert should only fire over sustained usage
because this is a symptom and may peak briefly during startup.
Set the timeout to 15m and slightly improve the alert message.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 11, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@openshift-cherrypick-robot: Bugzilla bug 1945431 has been cloned as Bugzilla bug 1992687. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1992687: alerts: SystemMemoryExceedsReservation triggers too quickly

In response to this:

[release-4.7] Bug 1945431: alerts: SystemMemoryExceedsReservation triggers too quickly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.7] Bug 1945431: alerts: SystemMemoryExceedsReservation triggers too quickly [release-4.7] Bug 1992687: alerts: SystemMemoryExceedsReservation triggers too quickly Aug 11, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1992687, which is invalid:

  • expected the bug to target the "4.7.z" release, but it targets "---" instead
  • expected Bugzilla bug 1992687 to depend on a bug targeting a release in 4.8.0, 4.8.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1992687: alerts: SystemMemoryExceedsReservation triggers too quickly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker
Copy link
Member

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@cblecker: This pull request references Bugzilla bug 1992687, which is invalid:

  • expected Bugzilla bug 1992687 to depend on a bug targeting a release in 4.8.0, 4.8.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker
Copy link
Member

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@cblecker: This pull request references Bugzilla bug 1992687, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1945431 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1945431 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0, 4.8.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker
Copy link
Member

/assign @yuqi-zhang
for review/approval

kikisdeliveryservice
kikisdeliveryservice approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This backport is fine.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 11, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021 •
edited

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-assisted bfa4009 link /test e2e-metal-assisted
ci/prow/e2e-vsphere-upgrade bfa4009 link /test e2e-vsphere-upgrade
ci/prow/okd-e2e-aws bfa4009 link /test okd-e2e-aws
ci/prow/okd-e2e-gcp-op bfa4009 link /test okd-e2e-gcp-op
ci/prow/okd-e2e-upgrade bfa4009 link /test okd-e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit 142d761 into openshift:release-4.7 Aug 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1992687 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1992687: alerts: SystemMemoryExceedsReservation triggers too quickly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker
Copy link
Member

Thanks @kikisdeliveryservice ! I'm going to pull this back to 4.6 as well, as that's when the alert was originally created.

/cherry-pick release-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 12, 2021
Merged
@openshift-cherrypick-robot
Copy link
Author

@cblecker: new pull request created: #2713

In response to this:

Thanks @kikisdeliveryservice ! I'm going to pull this back to 4.6 as well, as that's when the alert was originally created.

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

@cgwalters cgwalters Awaiting requested review from cgwalters

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

@cblecker cblecker

@kikisdeliveryservice kikisdeliveryservice

@yuqi-zhang yuqi-zhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @cblecker @openshift-bot @kikisdeliveryservice @bparees @yuqi-zhang @smarterclayton