Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

templates: [on-prem] NM prepender: ensure /etc/systemd/resolved.conf.d dir exists #2780

Merged
merged 1 commit into from
Oct 5, 2021
Merged

templates: [on-prem] NM prepender: ensure /etc/systemd/resolved.conf.d dir exists #2780

merged 1 commit into from
Oct 5, 2021

Conversation

LorbusChris
Copy link
Member

Fixes: okd-project/okd#690
See also: #2778

- How to verify it
OKD e2e

- Description for the changelog
templates: NM prepender: ensure /etc/systemd/resolved.conf.d dir exists

@kikisdeliveryservice kikisdeliveryservice changed the title templates: NM prepender: ensure /etc/systemd/resolved.conf.d dir exists templates: [on-prem] NM prepender: ensure /etc/systemd/resolved.conf.d dir exists Sep 28, 2021
mandre
mandre reviewed Oct 1, 2021
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2021
@kikisdeliveryservice
Copy link
Contributor

/test e2e-openstack
/test e2e-ovirt

@kikisdeliveryservice
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2021 •
edited
Loading

@LorbusChris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws b271422 link false /test okd-e2e-aws
ci/prow/e2e-aws-workers-rhel8 b271422 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-aws-workers-rhel7 b271422 link false /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-single-node b271422 link false /test e2e-aws-single-node
ci/prow/e2e-ovn-step-registry b271422 link false /test e2e-ovn-step-registry
ci/prow/e2e-aws-techpreview-featuregate b271422 link false /test e2e-aws-techpreview-featuregate
ci/prow/e2e-aws-disruptive b271422 link false /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cybertron
Copy link
Member

/lgtm
/retest-required

OCP doesn't use this code path so it shouldn't affect any of our platforms. Change makes sense though.

kikisdeliveryservice
kikisdeliveryservice approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the above reviews and ci results, approving.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, kikisdeliveryservice, LorbusChris, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 68c1b6b into openshift:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

@cybertron cybertron Awaiting requested review from cybertron

@EmilienM EmilienM Awaiting requested review from EmilienM

Assignees

@mandre mandre

@cybertron cybertron

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[4.7 vSphere IPI] systemd-resolved configuration fails on installation
7 participants
@LorbusChris @kikisdeliveryservice @cybertron @openshift-bot @mandre @openshift-merge-robot @vrutkovs