Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2011375: templates: Silence audit events from container infra by default #2792

Merged
merged 1 commit into from Oct 6, 2021
Merged

Bug 2011375: templates: Silence audit events from container infra by default #2792

merged 1 commit into from Oct 6, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2633

/assign kikisdeliveryservice

@cgwalters
templates: Silence audit events from container infra by default
7b8476f 
I was going to go add a check for "system has an AVC denial"
but the problem today is that every time a container starts or
stops *and* most notably liveness probes end up generating
audit events.

This very quickly rotates out audit events that we *do* care
about.

Outside of Kubernetes, workloads can be much more "static"
and it makes sense for "iptables rules changed" to cause an
audit event.  For OpenShift, it doesn't make sense.

Silence that and the promiscuous device one so that we can
more easily read the audit logs captured from a CI run to
verify there were no AVC denials.

This will also be useful preparation for e.g. teaching
the MCO do watch for some types of audit event (such as
AVC) and bridge them to Prometheus metrics or so.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 5, 2021
Merged
@kikisdeliveryservice kikisdeliveryservice changed the title [release-4.7] templates: Silence audit events from container infra by default [release-4.7] Bug 2011083: templates: Silence audit events from container infra by default Oct 5, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Oct 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2011083, which is invalid:

  • expected the bug to target the "4.7.z" release, but it targets "---" instead
  • expected Bugzilla bug 2011083 to depend on a bug targeting a release in 4.8.0, 4.8.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 2011083: templates: Silence audit events from container infra by default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 5, 2021
@kikisdeliveryservice kikisdeliveryservice changed the title [release-4.7] Bug 2011083: templates: Silence audit events from container infra by default [release-4.7] templates: Silence audit events from container infra by default Oct 5, 2021
@openshift-ci openshift-ci bot removed bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2021

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.7] templates: Silence audit events from container infra by default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice kikisdeliveryservice added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2021
@kikisdeliveryservice
Copy link
Contributor

this seems to need a 4.8 bz first. holding.

@kikisdeliveryservice
Copy link
Contributor

Pending: #2793

@sdodson
Copy link
Member

sdodson commented Oct 6, 2021

/retitle Bug 2011375: templates: Silence audit events from container infra by default

@openshift-ci openshift-ci bot changed the title [release-4.7] templates: Silence audit events from container infra by default Bug 2011375: templates: Silence audit events from container infra by default Oct 6, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2011375, which is invalid:

  • expected dependent Bugzilla bug 2011083 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
  • expected dependent Bugzilla bug 2011087 to target a release in 4.8.0, 4.8.z, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2011375: templates: Silence audit events from container infra by default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 6, 2021
@sdodson sdodson added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 6, 2021
@sdodson
Copy link
Member

sdodson commented Oct 6, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2021
@sdodson sdodson added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 6, 2021
@sdodson
Copy link
Member

sdodson commented Oct 6, 2021

/lgtm

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 6, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-cherrypick-robot, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-cherrypick-robot, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2021 •
edited

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-assisted 7b8476f link false /test e2e-metal-assisted
ci/prow/e2e-metal-ipi-ovn-dualstack 7b8476f link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi 7b8476f link false /test e2e-metal-ipi
ci/prow/okd-e2e-aws 7b8476f link false /test okd-e2e-aws
ci/prow/e2e-aws-serial 7b8476f link false /test e2e-aws-serial
ci/prow/okd-e2e-gcp-op 7b8476f link false /test okd-e2e-gcp-op
ci/prow/okd-e2e-upgrade 7b8476f link false /test okd-e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson
Copy link
Member

sdodson commented Oct 6, 2021

Most of those aws jobs are failing on [sig-api-machinery][Feature:APIServer][Late] kubelet terminates kube-apiserver gracefully [Suite:openshift/conformance/parallel] which has a bug associated with it but shows ~86% pass rate so odd to see it fail 3 times in a row but surely not due to this change. Once more to see what's up.

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit 74ab63b into openshift:release-4.7 Oct 6, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2011375 has been moved to the MODIFIED state.

In response to this:

Bug 2011375: templates: Silence audit events from container infra by default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

Assignees

@sdodson sdodson

@kikisdeliveryservice kikisdeliveryservice

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @kikisdeliveryservice @sdodson @openshift-bot @openshift-merge-robot @cgwalters