Bug 2031049: Fix panic when PlatformStatus VSphere is nil #2865

jcpowermac · 2021-12-10T17:55:55Z

This PR is to resolve a panic when
PlatformStatus.VSphere is nil.

This PR is to resolve a panic when `PlatformStatus.VSphere` is nil.

openshift-ci · 2021-12-10T17:55:58Z

@jcpowermac: This pull request references Bugzilla bug 2031049, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2031049: Fix panic when PlatformStatus VSphere is nil

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcpowermac · 2021-12-10T17:57:42Z

/bugzilla refresh

openshift-ci · 2021-12-10T17:57:50Z

@jcpowermac: This pull request references Bugzilla bug 2031049, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (rioliu@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcpowermac · 2021-12-10T17:58:02Z

/test e2e-vsphere
/test e2e-vsphere-upi

jcpowermac · 2021-12-10T18:05:56Z

I am still a little concerned about this. This section of code hasn't changed in 18 months.
And I am not entirely sure the scenario in which this occurs because based on CI results its not upi, ipi or platform none.

jcpowermac · 2021-12-10T18:06:50Z

cc: @sinnykumari

sinnykumari · 2021-12-13T08:55:38Z

pkg/operator/sync.go

@@ -353,8 +353,12 @@ func getIgnitionHost(infraStatus *configv1.InfrastructureStatus) (string, error)
 		case configv1.OvirtPlatformType:
 			ignitionHost = net.JoinHostPort(infraStatus.PlatformStatus.Ovirt.APIServerInternalIP, securePortStr)
 		case configv1.VSpherePlatformType:
-			if infraStatus.PlatformStatus.VSphere.APIServerInternalIP != "" {
-				ignitionHost = net.JoinHostPort(infraStatus.PlatformStatus.VSphere.APIServerInternalIP, securePortStr)
+			if infraStatus.PlatformStatus.VSphere != nil {


Indeed we haven't changed this code in a while, so wondering why we are hitting this bug now. My main concern is, is this something expected on vSphere to have infraStatus.PlatformStatus.VSphere nil or something is missing during vSphere cluster install. Also, can it cause any possible issue later with cluster where we are not adding securePortStr on a vSphere cluster?

Ah I think this was due to the recent PR merge to manage user data secret, as a result of

129d6e4#diff-3e205577bec1a1d1711df8bfeff30e63f044b24cfbdc69bbd7d0052fdc881891

and

59f1381#diff-3e205577bec1a1d1711df8bfeff30e63f044b24cfbdc69bbd7d0052fdc881891

Which we didn't do in sync.go prior to this since we (presumably) didn't need to figure out the ignition port. I may have been a little hasty on merging that PR. Maybe we can revisit that whole section? Otherwise the fix here (although it would get us past the failure) will still cause problems for the managed secret.

It looks like we may hit this bug on other platform handled in getIgnitionHost() right?
Jerry, since you have better context of #2827 , do you think it is better to revert the PR or check with PR author to see if we can fix the issue?

cc @zaneb

I think this is because some of the old ported code may not be updated with updated assumptions on what can be nil on what platform.

There's no immediate plans to use the managed secret in vSphere, so I think we should go ahead with this fix.

It's not clear to me why infraStatus.PlatformStatus would be non-nil but infraStatus.PlatformStatus.VSphere nil on a vSphere cluster.

Ok so I dug around for this, and we aren't exactly internally consistent on this either. Namely, we have 2 functions that query for this field,

in the operator:

machine-config-operator/pkg/operator/render.go

Line 272 in b50080b

func onPremPlatformAPIServerInternalIP(cfg mcfgv1.ControllerConfigSpec) (interface{}, error) {

- this doesn't actually seem to have that exact detection

in the template controller:

machine-config-operator/pkg/controller/template/render.go

Line 466 in aaa600e

func onPremPlatformAPIServerInternalIP(cfg RenderConfig) (interface{}, error) {

- This does have the extra detection and the reasoning.

I wonder why the operator one doesn't error. In any case I think we should probably look to de-duplicate the above 2 functions and then use the correct one here. At least we should be safe for the other platforms, so it's ok either way.

We can just merge this PR as is to unblock CI -> properly de-dupe as well.

sinnykumari

Approving based on the discussion on the PR and unblock CI. Let's handle any additional fixes that would be useful in a follow-up PR.

rvanderp3 · 2021-12-15T15:40:12Z

/lgtm

openshift-ci · 2021-12-15T15:40:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, rvanderp3, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-12-15T18:08:15Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-15T18:21:26Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-15T20:05:11Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-15T20:18:10Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-15T20:31:11Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-15T20:44:12Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-15T21:10:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-15T23:43:11Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-15T23:55:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T00:55:12Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T01:19:12Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T01:43:11Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T02:19:12Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T04:44:00Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T05:20:01Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T05:33:02Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T05:57:01Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T08:33:04Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T08:46:05Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

sinnykumari · 2021-12-16T09:18:40Z

/skip

openshift-ci · 2021-12-16T09:47:21Z

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere	`3f0b397`	link	false	`/test e2e-vsphere`
ci/prow/e2e-aws-single-node	`3f0b397`	link	false	`/test e2e-aws-single-node`
ci/prow/e2e-aws-upgrade-single-node	`3f0b397`	link	false	`/test e2e-aws-upgrade-single-node`
ci/prow/e2e-aws-disruptive	`3f0b397`	link	false	`/test e2e-aws-disruptive`
ci/prow/e2e-agnostic-upgrade	`3f0b397`	link	true	`/test e2e-agnostic-upgrade`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-12-16T10:12:06Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T10:36:07Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T12:37:19Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T14:55:55Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

sinnykumari · 2021-12-16T17:18:08Z

/test e2e-agnostic-upgrade

openshift-bot · 2021-12-16T20:46:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T22:49:46Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-17T01:25:49Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-17T03:28:15Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-17T06:03:37Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-17T08:26:34Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-12-17T12:32:29Z

@jcpowermac: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#2865

Bugzilla bug 2031049 has been moved to the MODIFIED state.

In response to this:

Bug 2031049: Fix panic when PlatformStatus VSphere is nil

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Fix panic when PlatformStatus VSphere is nil

3f0b397

This PR is to resolve a panic when `PlatformStatus.VSphere` is nil.

openshift-ci bot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Dec 10, 2021

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 10, 2021

openshift-ci bot requested review from jkyros and yuqi-zhang December 10, 2021 17:56

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 10, 2021

sinnykumari reviewed Dec 13, 2021

View reviewed changes

sinnykumari approved these changes Dec 15, 2021

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2021

openshift-ci bot assigned rvanderp3 Dec 15, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2021

openshift-merge-robot merged commit 0476b25 into openshift:master Dec 17, 2021

Bug 2031049: Fix panic when PlatformStatus VSphere is nil #2865

Bug 2031049: Fix panic when PlatformStatus VSphere is nil #2865

Conversation

jcpowermac commented Dec 10, 2021

openshift-ci bot commented Dec 10, 2021

jcpowermac commented Dec 10, 2021

openshift-ci bot commented Dec 10, 2021

jcpowermac commented Dec 10, 2021

jcpowermac commented Dec 10, 2021

jcpowermac commented Dec 10, 2021

sinnykumari Dec 13, 2021

Choose a reason for hiding this comment

yuqi-zhang Dec 14, 2021

Choose a reason for hiding this comment

sinnykumari Dec 14, 2021 • edited Loading

Choose a reason for hiding this comment

yuqi-zhang Dec 14, 2021

Choose a reason for hiding this comment

zaneb Dec 14, 2021

Choose a reason for hiding this comment

yuqi-zhang Dec 15, 2021

Choose a reason for hiding this comment

sinnykumari left a comment

Choose a reason for hiding this comment

rvanderp3 commented Dec 15, 2021

openshift-ci bot commented Dec 15, 2021

openshift-bot commented Dec 15, 2021

openshift-bot commented Dec 15, 2021

openshift-bot commented Dec 15, 2021

openshift-bot commented Dec 15, 2021

openshift-bot commented Dec 15, 2021

openshift-bot commented Dec 15, 2021

openshift-bot commented Dec 15, 2021

openshift-bot commented Dec 15, 2021

openshift-bot commented Dec 15, 2021

openshift-bot commented Dec 16, 2021

openshift-bot commented Dec 16, 2021

openshift-bot commented Dec 16, 2021

openshift-bot commented Dec 16, 2021

openshift-bot commented Dec 16, 2021

openshift-bot commented Dec 16, 2021

openshift-bot commented Dec 16, 2021

openshift-bot commented Dec 16, 2021

openshift-bot commented Dec 16, 2021

openshift-bot commented Dec 16, 2021

sinnykumari commented Dec 16, 2021

openshift-ci bot commented Dec 16, 2021

openshift-bot commented Dec 16, 2021

openshift-bot commented Dec 16, 2021

openshift-bot commented Dec 16, 2021

openshift-bot commented Dec 16, 2021

sinnykumari commented Dec 16, 2021

openshift-bot commented Dec 16, 2021

openshift-bot commented Dec 16, 2021

openshift-bot commented Dec 17, 2021

openshift-bot commented Dec 17, 2021

openshift-bot commented Dec 17, 2021

openshift-bot commented Dec 17, 2021

openshift-ci bot commented Dec 17, 2021

sinnykumari Dec 14, 2021 •

edited

Loading