Bug 2076521: mcc: update node sort to account for matching zones #3125
Conversation
openshift-ci
bot
added
bugzilla/severity-low
|
@kikisdeliveryservice: This pull request references Bugzilla bug 2076521, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
@kikisdeliveryservice: This pull request references Bugzilla bug 2076521, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@kikisdeliveryservice: This pull request references Bugzilla bug 2076521, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @cgwalters |
if nodes have same zone, sort by age oldest to newest Closes: Bug 2076521
kikisdeliveryservice
force-pushed
the
sort-by-age
branch
from
84ace6c
to
e51aca7
Compare
| newer_node_nozone.CreationTimestamp = metav1.NewTime(time.Unix(200, 30)) | ||
|
|
||
| newest_node_nozone := newNode("node-6", "v1", "v1") | ||
| newest_node_nozone := newNode("node-9", "v1", "v1") | ||
| newest_node_nozone.CreationTimestamp = metav1.NewTime(time.Unix(900, 30)) | ||
|
|
||
| nodes := []*corev1.Node{ |
There was a problem hiding this comment.
Optional (could be a followup): I think one thing that would build confidence even more is we could randomly permute this list a few times and verify we get the same sorted list each time.
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kikisdeliveryservice, sergiordlr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@kikisdeliveryservice: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@kikisdeliveryservice: All pull requests linked via external trackers have merged: Bugzilla bug 2076521 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add check for nodes with matching zones, in this case, sort by age oldest to newest.
Also added some test case coverage for this and refactor existing test cases to all have a standardized declaration.
Closes: BZ 2076521