Remove onPremPlatformKeepalivedEnableUnicast function

[EmilienM]

This isn't used anymore since we enabled Unicast for all on-prem
platforms which use Keepalived, via #3016.

[EmilienM]

/test e2e-openstack

[EmilienM]

/test e2e-metal-ipi
/test e2e-vsphere-upgrade

[EmilienM]

/cc mandre

[mandre]

/lgtm
/assign @cybertron

[cybertron]

I actually left these on purpose because I'm not sure what the order of operations for upgrades is and we've had problems in the past with old templates being rendered with new code (or vice versa). If we wait to remove these functions until 4.12 then we don't have to worry about that.

I guess if someone can verify that this doesn't cause any problems on upgrade we can go ahead and merge it, but otherwise I'd prefer to just wait.

/hold
until either 4.12 or verification of upgrades

[mandre]

I actually left these on purpose because I'm not sure what the order of operations for upgrades is and we've had problems in the past with old templates being rendered with new code (or vice versa). If we wait to remove these functions until 4.12 then we don't have to worry about that.

That's good to know, I hadn't thought about the possibility of having an old template using new binaries for rendering, although I don't exactly understand how this would happen 😄
We're past feature freeze anyway, and this would need a BZ if we wanted to merge the patch now. It clearly doesn't qualify as a bug, so it makes total sense to wait until master re-opens, for both safety and convenience.

[cybertron]

/test e2-vsphere-upgrade
/test e2e-metal-ipi
/test e2e-openstack
/hold cancel
/lgtm

4.12 is open, so this is good to go. Just re-running the on-prem jobs to make sure nothing broke in the meantime.

[cybertron]

/test e2e-metal-ipi
/test e2e-openstack
/test e2e-vsphere-upgrade

[sinnykumari]

/retest

[cybertron]

/retest

[mandre]

This should be good to go now, I believe.
/assign sinnykumari

[sinnykumari]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, EmilienM, mandre, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@EmilienM: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.