Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.8] Bug 2109329: Avoid kubernetes node port range #3316

Merged
merged 1 commit into from
Oct 12, 2022
Merged

[release-4.8] Bug 2109329: Avoid kubernetes node port range #3316

merged 1 commit into from
Oct 12, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #3255

/assign cybertron

@cybertron
Avoid kubernetes node port range
5a3cc9d 
Per [0], the range 30000-32767 is used for kubernetes node ports.
We should not have haproxy listening in that range to avoid possible
conflicts.

9444 is adjacent to 9445 where the haproxy frontend listens, but is
currently unused in the host port registry.

0: https://github.com/openshift/openshift-docs/blob/main/modules/installation-network-user-infra.adoc
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 29, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 29, 2022

@openshift-cherrypick-robot: Detected clone of Bugzilla bug 2101794 with correct target release. Retitling PR to link to clone:
/retitle [release-4.8] Bug 2109329: Avoid kubernetes node port range

In response to this:

[release-4.8] Bug 2101794: Avoid kubernetes node port range

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.8] Bug 2101794: Avoid kubernetes node port range [release-4.8] Bug 2109329: Avoid kubernetes node port range Aug 29, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 29, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2109329, which is invalid:

  • expected dependent Bugzilla bug 2101794 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.8] Bug 2109329: Avoid kubernetes node port range

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cybertron
Copy link
Member

/retest-required
/test e2e-metal-ipi
/test e2e-openstack

@cybertron
Copy link
Member

/retest-required

@cybertron
Copy link
Member

/bugzilla refresh
/label backport-risk-assessed
/retest-required
/test e2e-openstack
/test e2e-metal-ipi

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2022

@cybertron: This pull request references Bugzilla bug 2109329, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2101794 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2101794 targets the "4.9.z" release, which is one of the valid target releases: 4.9.0, 4.9.z
  • bug has dependents

Requesting review from QA contact:
/cc @siserafin

In response to this:

/bugzilla refresh
/label backport-risk-assessed
/retest-required
/test e2e-openstack
/test e2e-metal-ipi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cybertron
Copy link
Member

/lgtm
/assign @kikisdeliveryservice
@reihl Can you approve this cherry-pick please?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2022
@cybertron
Copy link
Member

/retest-required
/test e2e-openstack
/test e2e-metal-ipi

@sinnykumari
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, openshift-cherrypick-robot, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2022
@cybertron
Copy link
Member

/retest-required

The openstack failure is a known issue (which has a fix in flight) and highly unlikely to be related to this patch.

@reihl We also still need approval from you on this.

@cybertron
Copy link
Member

/test e2e-openstack
/retest-required

1 similar comment
@cybertron
Copy link
Member

/test e2e-openstack
/retest-required

@openshift-ci openshift-ci bot mentioned this pull request Sep 20, 2022
Merged
@cybertron
Copy link
Member

/test e2e-openstack
/retest-required

@cybertron
Copy link
Member

/retest-required
/test e2e-openstack

@cybertron
Copy link
Member

/retest-required

I don't see how this could possible be breaking agnostic upgrade when the files changed are not even used on the platform for that job.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2022 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-upgrade 5a3cc9d link false /test okd-e2e-upgrade
ci/prow/okd-e2e-aws 5a3cc9d link false /test okd-e2e-aws
ci/prow/e2e-metal-assisted 5a3cc9d link false /test e2e-metal-assisted
ci/prow/e2e-openstack 5a3cc9d link false /test e2e-openstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cybertron
Copy link
Member

/retest-required

@cybertron
Copy link
Member

@reihl This is now passing ci so it should be ready for cherry-pick-approved. Thanks!

@reihl
Copy link

reihl commented Oct 12, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 12, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 30c5add and 2 for PR HEAD 5a3cc9d in total

@openshift-merge-robot openshift-merge-robot merged commit ec89823 into openshift:release-4.8 Oct 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2109329 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 2109329: Avoid kubernetes node port range

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinnykumari sinnykumari sinnykumari approved these changes

@mdbooth mdbooth Awaiting requested review from mdbooth

@rgolangh rgolangh Awaiting requested review from rgolangh

@siserafin siserafin Awaiting requested review from siserafin

Assignees

@cybertron cybertron

@kikisdeliveryservice kikisdeliveryservice

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@openshift-cherrypick-robot @cybertron @sinnykumari @reihl @openshift-ci-robot @kikisdeliveryservice @openshift-merge-robot