MCO-424: Drop machine-os-content references

[cgwalters]

xref https://github.com/openshift/enhancements/blob/master/enhancements/ocp-coreos-layering/ocp-coreos-layering.md

This is part of https://issues.redhat.com/browse/MCO-392

Since we've landed the new format image usage in the latest nightly, it's time to try dropping it from our image references entirely.

[cgwalters]

OK we're passing our own CI here. I think we can likely do this, and then the actual removal would hinge on openshift/driver-toolkit#101

[yuqi-zhang]

/test e2e-hypershift

Wanted to check if this was actually added or not

[yuqi-zhang]

/test okd-scos-images

[cgwalters]

Let's merge openshift/driver-toolkit#102 first, because this repository is the real logical owner of machine-os-content, and we have tons of existing CI jobs setup here we can use to gain signal for its final removal.
/hold

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cgwalters]

Let's merge openshift/driver-toolkit#102 first, because this repository is the real logical owner of machine-os-content, and we have tons of existing CI jobs setup here we can use to gain signal for its final removal.

While this is true, I think it will actually be better to leave driver-toolkit as the last thing holding the bag. We can merge this, and then do the driver-toolkit change and the change to openshift/os#1374 as the same time.

[openshift-ci]

@cgwalters: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws	c78dbe1	link	true	/test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[cgwalters]

See discussion in openshift/os#1374

[openshift-ci-robot]

@cgwalters: This pull request references MCO-424 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

xref https://github.com/openshift/enhancements/blob/master/enhancements/ocp-coreos-layering/ocp-coreos-layering.md

This is part of https://issues.redhat.com/browse/MCO-392

Since we've landed the new format image usage in the latest nightly, it's time to try dropping it from our image references entirely.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cgwalters]

OK yep, green for CI across the board here, and this is basically purely deleting dead code. Risk here is IMO quite low.

[yuqi-zhang]

Reading through the context I think this should be safe to drop on our side. Offhand I don't think any non-CI covered paths (hypershift, IBM cloud, onceFrom etc.) uses this anymore as well

/lgtm
/hold

For QE verification in case we're missing something

[openshift-ci-robot]

@cgwalters: This pull request references MCO-424 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

xref https://github.com/openshift/enhancements/blob/master/enhancements/ocp-coreos-layering/ocp-coreos-layering.md

This is part of https://issues.redhat.com/browse/MCO-392

Since we've landed the new format image usage in the latest nightly, it's time to try dropping it from our image references entirely.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, travier, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cgwalters,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cgwalters]

For QE verification in case we're missing something

In this case what would QE do that would not be covered by presubmits?

[yuqi-zhang]

I thought of it as they have a larger test suite compared to CI, but I guess that might not be relevant for this PR. Feel free to unhold if we believe this doesn't require additional testing

[cgwalters]

Yes I think QE capacity is better focused on other things honestly (like #3865 )

At this point the technical debt from this dis-proportionally impacts the CoreOS team. But I also know if something breaks from this the first bug contact will be the MCO team as usual.

Dunno, bottom line we can see if someone from the QE team says "yes there's some test we have which may be relevant" or not. We have a large complex system, in theory somehow maybe somehow this breaks scaleup from old bootimages for example, but I don't think that's likely.

[yuqi-zhang]

/hold cancel

I'm convinced 👍

[openshift-ci-robot]

@cgwalters: This pull request references MCO-424 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

xref https://github.com/openshift/enhancements/blob/master/enhancements/ocp-coreos-layering/ocp-coreos-layering.md

This is part of https://issues.redhat.com/browse/MCO-392

Since we've landed the new format image usage in the latest nightly, it's time to try dropping it from our image references entirely.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.