COS-2473: Re-enable ostree-container-inject-openshift-cvo-labels knob
#1374
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
approved
|
This would go at the same time as openshift/driver-toolkit#135. |
|
I'm ok with trying to just change everything at once, but I think we need to give a heads up to stakeholders. |
Sounds good. Anyone other than those listed in the previous comment? I guess there's the MCO team too. |
|
I rebased openshift/machine-config-operator#3364 FWIW, so I think we can get down to just two things that need to change at the same time, not 3. |
This was previously enabled (openshift#1048) and then disabled again (openshift#1084) because `oc` doesn't know how to handle multiple images with those labels in the release payload. We'll need to solve this eventually if we want to be able to ship multiple OS images in the payload (that's tracked in openshift#1047), but we don't need to block on this if we can remove the legacy `machine-os-content` at the same time. See also: openshift/driver-toolkit#101 See also: openshift/machine-config-operator#3364
jlebon
force-pushed
the
pr/rhel-coreos-labels
branch
from
32e890c
to
12a9a69
Compare
|
/hold |
openshift-ci
bot
added
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon, travier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jlebon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Just so we don't spend too much time playing the coordination game, let's go ahead and merge this. It seems OK if 4.15 is rocky for a bit until the other PRs merge. /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
jlebon
changed the title
ostree-container-inject-openshift-cvo-labels knobostree-container-inject-openshift-cvo-labels knob
openshift-ci-robot
added
the
jira/valid-reference
|
@jlebon: This pull request references COS-2473 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This was previously enabled (openshift#1048, openshift#1374) and then disabled again (openshift#1084, openshift#1393). The last time we tried it, the issue was that there were some references remaining in openshift/kubernetes and openshift/release. Those have been cleaned up now: openshift/release#49156 openshift/kubernetes#1805 So... third time's the charm!
This was previously enabled (openshift#1048, openshift#1374) and then disabled again (openshift#1084, openshift#1393). The last time we tried it, the issue was that there were some references remaining in openshift/kubernetes and openshift/release. Those have been cleaned up now: openshift/release#49156 openshift/kubernetes#1805 So... third time's the charm!
This was previously enabled (#1048) and then disabled again (#1084) because
ocdoesn't know how to handle multiple images with those labels in the release payload. We'll need to solve this eventually if we want to be able to ship multiple OS images in the payload (that's tracked in #1047), but we don't need to block on this if we can remove the legacymachine-os-contentat the same time.See also: openshift/driver-toolkit#101
See also: openshift/machine-config-operator#3364