-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move envtest helpers into framework package for easier reuse #3428
move envtest helpers into framework package for easier reuse #3428
Conversation
40685ee
to
7fb6532
Compare
7fb6532
to
36ca121
Compare
Converting to draft to conserve CI resources while I debug the bootstrap-unit stage. |
6ccee50
to
84f3736
Compare
7a46721
to
afef4bc
Compare
This is now ready for review! |
a3105e9
to
1e2d387
Compare
037bc77
to
4cfbb8a
Compare
/test bootstrap-unit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally lgtm! Tested locally as well just to make sure and all the tests seem to run as expected.
Will let others give a look as well before lgtm
- collect golangci-lint output as junit - conditionally install required tools
4cfbb8a
to
d37c3e9
Compare
@cheesesashimi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheesesashimi, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- What I did
I moved the EnvTest setup and environment cleanup code into the
test/framework
package for easier reuse across the rest of the MCO codebase. Additionally, I refactored the Makefile as well as some of the test scripts to collect JUnit test reports in CI as well as a test coverage report.- How to verify it
Because
test/e2e-bootstrap
is the only test suite that uses EnvTest, one can run$ make bootstrap-e2e
or run the test target via/test bootstrap-unit
. (For some unknown reason, we're not runningbootstrap-unit
on each PR, though it makes sense to because they're not overly resource intensive and execute quickly.)For the JUnit and test coverage reports, open the links for the various Prow CI jobs and you should see them enumerated in the Test Results pane as well as a red / green graphic illustrating test coverage.
- Description for the changelog
Move EnvTest helpers into framework package for easier reuse