OCPBUGS-4476, OCPBUGS-11702: keepalived/ingress: change healthcheck script #3441
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
mandre
force-pushed
the
scale-keepalived
branch
from
4f177e4
to
30f8134
Compare
|
/retitle Bug OCPBUGS-4476: keepalived/ingress: change healthcheck script |
openshift-ci
bot
changed the title
|
@EmilienM: This pull request references Jira Issue OCPBUGS-4476, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/invalid-bug
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/jira refresh |
openshift-ci-robot
added
jira/severity-important
|
@mandre: This pull request references Jira Issue OCPBUGS-4476, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
Correct, this is only for on-prem platforms: Baremetal, vSphere, OpenStack, oVirt. Let's give a chance for other platforms to review the patch, in particular I'd like @cybertron to take a look. |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test ? |
|
@mandre: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-openstack |
|
/assign @cybertron |
@EmilienM @mandre |
openshift-ci
bot
removed
the
lifecycle/stale
|
/lgtm |
|
/retitle OCPBUGS-4476, OCPBUGS-11702: keepalived/ingress: change healthcheck script |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@EmilienM: This pull request references Jira Issue OCPBUGS-11702, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@mkowalski: This pull request references Jira Issue OCPBUGS-11702, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Tried the new command out locally and it seems to be doing the right thing, and it's now less likely to match things it shouldn't so |
|
Who's best to assign for this? Maybe /assign cgwalters |
| @@ -3,4 +3,4 @@ path: "/etc/kubernetes/static-pod-resources/keepalived/scripts/chk_default_ingre | |||
| contents: | |||
| inline: | | |||
| #!/bin/bash | |||
| /host/bin/oc --kubeconfig /var/lib/kubelet/kubeconfig get ep -n openshift-ingress router-internal-default -o yaml | grep -q 'ip: {{`{{.NonVirtualIP}}`}}$' | |||
| /host/bin/crictl -r unix:///host/run/crio/crio.sock pods --namespace openshift-ingress --state Ready | grep -q 'router-default-[[:xdigit:]]\{10\}-[[:alnum:]]\{5\}' | |||
There was a problem hiding this comment.
We have recently seen some bugs around older bootimages during scale-up. Since we are going to switch to use crirctl, can you please confirm if this crictl functionality was present in crictl shipped in OCP 4.1 bootimage?
There was a problem hiding this comment.
To add to the comment above (because it's not trivial to find this out), OCP 4.1 bootimage corresponds to the RHCOS 410.8.20190520.0
There was a problem hiding this comment.
Seems to me like crictl back in OCP 4.1 bootimage contains what we need here, i.e. pods command
There was a problem hiding this comment.
Thanks for confirming!
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cybertron, dougsland, EmilienM, mkowalski, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/unhold Unholding as it's been reviewed by Bare Metal Networking Team |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-merge-robot
merged commit 4fef556
into
openshift:master
|
@EmilienM: Jira Issue OCPBUGS-11702: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-11702 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mandre: new pull request created: #3687 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Inspect the local containers with crictl instead of querying the
API server which can be very problematic at scale.